🎬 ipad-de-01 | Center form vertically on ipad and increase gaps between buttons – ⏰ 8.11.
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	tmletzko
	Nov 1 2019, 2:41 PM

Description

Our current best banner on ipads has its form on the right side. As the current form display on the right side esp. on the portrait mode does not look that good, we try to optimize the design of the right-side form.

Acceptance criterias

the progress bar is implemented
the copy is

"Liebe Leserinnen und Leser, verzeihen Sie die Störung. An diesem [day] sind Sie in Deutschland gefragt:
Wikipedia wird durch Spenden von durchschnittlich 23,83 € finanziert, aber 99 % der Leserinnen und Leser spenden nicht. Wenn alle, die das jetzt lesen, einen kleinen Beitrag leisten, wäre unser Spendenziel bereits am heutigen Mittwoch erreicht. Schon der Preis einer Tasse Kaffee würde genügen. Über 6 Millionen Mal wird unser Spendenaufruf täglich angezeigt, aber nur 377.589 Menschen haben bisher gespendet. Sicher könnten wir mit Werbung eine Menge Geld verdienen. Aber dann wäre Wikipedia komplett anders. Wir könnten ihr nicht vertrauen. Es ist leicht, diese Nachricht zu ignorieren und die meisten werden das wohl tun. Wenn Sie Wikipedia nützlich finden, nehmen Sie sich an diesem [day] bitte eine Minute Zeit und geben Wikipedia mit Ihrer Spende etwas zurück. Vielen Dank!

both banners have the same height in portrait and landscape mode
the Mittelverwendung needs to be updated before enabling (T237231)

Related Objects
Search...

Status	Assigned	Task
Resolved	kai.nissen	T235509 🎬 ipad-de-01 & desktop-en-01 \| Data export – ⏰ 26.11.
Resolved	None	T235508 🎬 ipad-de-01 \| Campaign setup – ⏰ 8.11.
Resolved	None	T237110 🎬 ipad-de-01 \| Center form vertically on ipad and increase gaps between buttons – ⏰ 8.11.

Event Timeline

tmletzko created this task.Nov 1 2019, 2:41 PM

• Tim_WMDE moved this task from Heap to Code Review on the WMDE-FUN-Funban-2019 board.Nov 2 2019, 5:19 PM

Specs for this ticket were scribbled on paper in a session with Jan. You can see the changes I have made in the "Implement VAR for C19_WMDE_ipad_Test_01" commit here: https://github.com/wmde/fundraising-banners/pull/258/commits

Banners are here, differences are mostly visible when viewing in iPad resolutions (use the browser functionality for that):

https://de.m.wikipedia.org/?banner=B19_WMDE_ipad_01_ctrl
https://de.m.wikipedia.org/?banner=B19_WMDE_ipad_01_var

Progress bar is left in "broken" state with regards to the upcoming refactoring of the progress bar.

• Tim_WMDE removed • Tim_WMDE as the assignee of this task.Nov 3 2019, 11:44 AM

• Tim_WMDE subscribed.

• chrp renamed this task from Center form on ipad and increase gaps between buttons to ipad-01: Center form on ipad and increase gaps between buttons.Nov 4 2019, 12:34 PM

• chrp renamed this task from ipad-01: Center form on ipad and increase gaps between buttons to ipad-de-01 | Center form vertically on ipad and increase gaps between buttons – ⏰ 10.11..Nov 4 2019, 1:56 PM

• chrp renamed this task from ipad-de-01 | Center form vertically on ipad and increase gaps between buttons – ⏰ 10.11. to 🎬 ipad-de-01 | Center form vertically on ipad and increase gaps between buttons – ⏰ 10.11..

There are issues with the height of the progress bar, see screenshots attached:

Screenshot 2019-11-04 at 14.58.36.png (1×3 px, 569 KB)

Screenshot 2019-11-04 at 14.58.29.png (1×3 px, 556 KB)

• chrp moved this task from Code Review to Heap on the WMDE-FUN-Funban-2019 board.Nov 4 2019, 2:00 PM

This is how the forms looks vertically centered in portrait & landscape mode:

Screenshot 2019-11-04 at 15.03.04.png (1×2 px, 550 KB)

Screenshot 2019-11-04 at 15.02.53.png (1×2 px, 541 KB)

Looks good to me.

gabriel-wmde claimed this task.Nov 5 2019, 8:49 AM

gabriel-wmde moved this task from Heap to Doing on the WMDE-FUN-Funban-2019 board.

gabriel-wmde reassigned this task from gabriel-wmde to • Tonina_Zhelyazkova_WMDE.Nov 6 2019, 10:11 AM

gabriel-wmde subscribed.

tmletzko updated the task description. (Show Details)Nov 6 2019, 2:56 PM

~~@tmletzko Why is Mittelverwendung T237231 a dependency of especially this task?~~

EDIT: I've seen that that you've added this as a dependency in other tickets as well. See my comment in the actual ticket T237231.

Remove the "Noch xxx Tage:" label for now.
Move the labels into the progress bar
Make sure to remove the black dot on the right side of the progress bar

• chrp renamed this task from 🎬 ipad-de-01 | Center form vertically on ipad and increase gaps between buttons – ⏰ 10.11. to 🎬 ipad-de-01 | Center form vertically on ipad and increase gaps between buttons – ⏰ 8.11..Nov 7 2019, 5:30 PM

the modification to "Wikipedia wird durch Spenden von durchschnittlich 23,83 € finanziert, aber 99 % der Leserinnen und Leser spenden nicht." is still missing (21,48 -> 23,83)
the parameter "dsn=0" is included. I guess this can be excluded?
tracks look good though

Updated the numbers and removed dsn param

still needs to be fixed

Remove the "Noch xxx Tage:" label for now.
Move the labels into the progress bar
Make sure to remove the black dot on the right side of the progress bar

@gabriel-wmde

• chrp removed • Tonina_Zhelyazkova_WMDE as the assignee of this task.Nov 8 2019, 7:08 PM

• chrp moved this task from Acceptance Test to Heap on the WMDE-FUN-Funban-2019 board.

• chrp added a subscriber: • Tonina_Zhelyazkova_WMDE.

@tmletzko I have taken care of this, please test.

• Tim_WMDE moved this task from Heap to Code Review on the WMDE-FUN-Funban-2019 board.Nov 9 2019, 10:21 PM

• Tim_WMDE moved this task from Code Review to Acceptance Test on the WMDE-FUN-Funban-2019 board.

it all looks good. tracks are in. the only thing is the dsn=0 url parameter. I think this can de removed. otherwise, it is ready to go. thanks. @Tim_WMDE

I have removed the parameter.

@JanJaquemot @tmletzko Accepted?

yes

• chrp moved this task from Acceptance Test to Deploy on the WMDE-FUN-Funban-2019 board.Nov 11 2019, 9:47 AM

• Tonina_Zhelyazkova_WMDE unsubscribed.Nov 11 2019, 11:35 AM

• chrp closed this task as Resolved.Nov 11 2019, 3:46 PM

• chrp moved this task from Deploy to Done on the WMDE-FUN-Funban-2019 board.

	F30986356: Screenshot 2019-11-04 at 15.03.04.png
	Nov 4 2019, 2:04 PM

	F30986358: Screenshot 2019-11-04 at 15.02.53.png
	Nov 4 2019, 2:04 PM

	F30986320: Screenshot 2019-11-04 at 14.58.29.png
	Nov 4 2019, 1:59 PM

	F30986318: Screenshot 2019-11-04 at 14.58.36.png
	Nov 4 2019, 1:59 PM

🎬 ipad-de-01 | Center form vertically on ipad and increase gaps between buttons – ⏰ 8.11.Closed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

🎬 ipad-de-01 | Center form vertically on ipad and increase gaps between buttons – ⏰ 8.11.
Closed, ResolvedPublic
Actions

Related Objects
Search...