@ReleaseTaggerBot (forrestbot) crashing when parsing a r/485486 from extension-Wikisource
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MarcoAurelio
	Nov 1 2019, 2:58 PM

Description

Parsing https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikisource/+/485486/ made ReleaseTaggerBot crash. Details:

2019-11-01 14:01:37,549 - forrestbot - INFO - Processing https://gerrit.wikimedia.org/r/485486
2019-11-01 14:01:37,550 - root - DEBUG - Requesting 'master' branches for mediawiki/extensions/Wikisource
2019-11-01 14:01:37,552 - requests.packages.urllib3.connectionpool - INFO - Starting new HTTPS connection (1): gerrit.wikimedia.org
2019-11-01 14:01:37,696 - forrestbot - ERROR - Releasetaggerbot crashed while processing messages
Traceback (most recent call last):
  File "/data/project/forrestbot/forrestbot/forrestbot.py", line 209, in <module>
    main()
  File "/data/project/forrestbot/forrestbot/forrestbot.py", line 154, in main
    action = process_mail(mail)
  File "/data/project/forrestbot/forrestbot/forrestbot.py", line 116, in process_mail
    taskbranches = get_master_branches(proj)
  File "/data/project/forrestbot/forrestbot/forrestbot.py", line 46, in get_master_branches
    key=wmf_number)[-1]
IndexError: list index out of range

Event Timeline

MarcoAurelio created this task.Nov 1 2019, 2:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2019, 2:58 PM

MarcoAurelio renamed this task from @ReleaseTaggerBot (forrestbot) crashing when parsing a repository to @ReleaseTaggerBot (forrestbot) crashing when parsing a r/485486 from extension-Wikisource.Nov 1 2019, 2:58 PM

MarcoAurelio triaged this task as Medium priority.

I wonder if this is due to https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/release/+/547216/.

In T237111#5626872, @MarcoAurelio wrote:

I wonder if this is due to https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/release/+/547216/.

I'd be surprised, but just in case I've manually created wmf.4.

Yup, that fixed it. Fun.

Thanks for noticing & fixing this -- I had received a bunch of alerts, but didn't have time to look into it until tonight (and given that RTB is not super time critical I thought I would be in time -- but y'all were faster! :-)).

@ReleaseTaggerBot (forrestbot) crashing when parsing a r/485486 from extension-WikisourceClosed, ResolvedPublicActions

Description

Event Timeline

@ReleaseTaggerBot (forrestbot) crashing when parsing a r/485486 from extension-Wikisource
Closed, ResolvedPublic
Actions