Curator gets limited revision count
Closed, ResolvedPublic
Actions

Description

"As a Curator, I want to know if I've hit a limit in a revision count call, so I can know that there are 'a lot' of edits without having an exact number."

This user story comes out of the discussion around minor revision count T234941, since it's an expensive query and we want to limit the results. The intermediate count between two revisions T235666 has a similar limit.

We'd like all of the revision count endpoints to support limits in their results:

bot revisions T231354
reverted revisions T231351
anonymous revisions T231352
total revisions T231348
unique editors T231349

The results should be limited to 1000 for each endpoint.

Each endpoint should have an additional output property, limit, that is set to true if the real value for the count is strictly greater than the limit.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add limit: false to the expected history count responses	mediawiki/tools/api-testing	master	+5 -5
	REST History Counts: Limit the number of edits to count	mediawiki/core	master	+29 -35

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Invalid		None	T234951 Extended history API
		Resolved		• eprodromou	T237115 Curator gets limited revision count

Event Timeline

• eprodromou created this task.Nov 1 2019, 3:54 PM

• eprodromou updated the task description. (Show Details)

• eprodromou mentioned this in T235666: REST: Add 'from' and 'to' parameters to historycount endpoint..

Change 547682 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] REST History Counts: Limit the number of edits to count

https://gerrit.wikimedia.org/r/547682

gerritbot added a project: Patch-For-Review.Nov 4 2019, 9:05 PM

Change 548799 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/tools/api-testing@master] Add limit: false to the expected history count responses

https://gerrit.wikimedia.org/r/548799

Updated the docs with a limit of 500 for all history count types.

In T237115#5637180, @apaskulin wrote:

Updated the docs with a limit of 500 for all history count types.

I think the above says 1000.

I should have clarified: Looking at the implementation, I'm seeing a limit of 500, which appears to conflict with the task description.

• eprodromou moved this task from Backlog to Needs Review on the Platform Team Workboards (User Stories) board.Nov 6 2019, 7:40 PM

• eprodromou triaged this task as Medium priority.Nov 6 2019, 9:03 PM

• eprodromou lowered the priority of this task from Medium to Low.

Updated the patch to set the limit to 1000.

Change 547682 merged by jenkins-bot:
[mediawiki/core@master] REST History Counts: Limit the number of edits to count

https://gerrit.wikimedia.org/r/547682

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 7 2019, 7:00 AM

In T237115#5641614, @apaskulin wrote:

I should have clarified: Looking at the implementation, I'm seeing a limit of 500, which appears to conflict with the task description.

OMG we are going to have the most accurate documentation on the planet