| kaldari | |
| Nov 1 2019, 6:28 PM |
| F30948534: Screen Shot 2019-11-01 at 4.05.26 PM.png | |
| Nov 1 2019, 8:07 PM |
| F30948538: Screen Shot 2019-11-01 at 4.04.15 PM.png | |
| Nov 1 2019, 8:07 PM |
| F30948405: Screen Shot 2019-11-01 at 3.58.04 PM.png | |
| Nov 1 2019, 8:01 PM |
| F30948411: Screen Shot 2019-11-01 at 3.58.23 PM.png | |
| Nov 1 2019, 8:01 PM |
| F30947274: Screen Shot 2019-11-01 at 2.25.25 PM.png | |
| Nov 1 2019, 6:28 PM |
| F30947298: Screen Shot 2019-11-01 at 2.27.20 PM.png | |
| Nov 1 2019, 6:28 PM |
| F30947265: Screen Shot 2019-11-01 at 2.15.41 PM.png | |
| Nov 1 2019, 6:28 PM |
| F30947245: Screen Shot 2019-11-01 at 2.12.09 PM.png | |
| Nov 1 2019, 6:28 PM |
The Upload interface (step 2) in UploadWizard is messed up and some important parts of the UI are not visible to the user.
What it currently looks like:
What it used to look like:
Note that this affects all file uploads, not just duplicate files as shown in the screenshots above.
Confirmed in both Chrome and Firefox with multiple skins in safe mode.
@matthiasmullie @Volker_E - No idea what caused this, but any chance one of you could look into this?
It looks like the placement of the mwe-upwiz-file-texts div in the DOM has changed.
Old DOM:
New DOM:
Looks like @Esanders inadvertently broke it while making the code more linter compliant:
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UploadWizard/+/541298/1/resources/mw.UploadWizardUploadInterface.js
Note the sneaky self closing div on line 30 that was accidentally changed into an opening div tag.
Change 547783 had a related patch set uploaded (by Kaldari; owner: Kaldari):
[mediawiki/extensions/UploadWizard@master] Fixing DOM in upload interface of UploadWizard
Change 547783 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Fixing DOM in upload interface of UploadWizard
Change 547794 had a related patch set uploaded (by Jforrester; owner: Kaldari):
[mediawiki/extensions/UploadWizard@wmf/1.35.0-wmf.4] Fixing DOM in upload interface of UploadWizard
Change 547794 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@wmf/1.35.0-wmf.4] Fixing DOM in upload interface of UploadWizard
Mentioned in SAL (#wikimedia-operations) [2019-11-01T21:20:35Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.4/extensions/UploadWizard/resources/mw.UploadWizardUploadInterface.js: T237126 Fixing DOM in upload interface of UploadWizard (duration: 00m 56s)