Page MenuHomePhabricator
Create Task
Maniphest T237149

Arabic text overlaying on icon
Closed, ResolvedPublic
Actions

Description

The text in the suggestion task introduction is misplaced, it is overlaying the icon in the left.

Maybe the icon should be in the right of the window.

Sans titre.png (701×451 px, 74 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
StartEditingDialog: Make difficulty-square image positioning work in RTLCatropemediawiki/extensions/GrowthExperimentsmaster+3 -2
Customize query in gerrit

Event Timeline

Dyolf77_WMF created this task.Nov 2 2019, 9:13 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 2 2019, 9:13 AM
Restricted Application added subscribers: alaa, Aklapper. · View Herald Transcript
Dyolf77_WMF updated the task description. (Show Details)Nov 2 2019, 9:15 AM
gerritbot added a comment.Nov 2 2019, 9:03 PM

Change 547797 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Make difficulty-square image positioning work in RTL

https://gerrit.wikimedia.org/r/547797

gerritbot added a project: Patch-For-Review.Nov 2 2019, 9:03 PM
Catrope claimed this task.Nov 2 2019, 9:03 PM
Catrope edited projects, added: GrowthExperiments-NewcomerTasks, Growth-Team (Sprint 0 (Growth Team)); removed: Growth-Team, GrowthExperiments.
Catrope moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Catrope added a comment.Nov 2 2019, 9:07 PM

With my patch:

Screenshot from 2019-11-02 14-06-16.png (725×497 px, 59 KB)

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 4 2019, 9:48 AM
gerritbot added a comment.Nov 4 2019, 10:00 AM

Change 547797 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Make difficulty-square image positioning work in RTL

https://gerrit.wikimedia.org/r/547797

Maintenance_bot removed a project: Patch-For-Review.Nov 4 2019, 10:10 AM
Dyolf77_WMF closed this task as Resolved.Nov 4 2019, 10:36 AM

Thanks @Catrope, it is fixed now.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Nov 4 2019, 11:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits