Page MenuHomePhabricator

Cloud VPS MediaWiki-Vagrant root URL should not redirect from HTTPS to HTTP
Closed, ResolvedPublic

Description

$ curl -v https://wikispore.wmflabs.org
...
< location: http://wikispore.wmflabs.org/w/index.php

That's not great.

Event Timeline

Note that the HTTPS role was not enabled. Maybe that would help? (Although most of it is not functional in Cloud VPS.)

Possibly happening because of RewriteRule ^/$ /w/index.php [R=301] in the base Apache2 config (puppet/modules/mediawiki/templates/mediawiki-apache-site.erb)? I think that once MediaWiki is involved in the rewrites that it does properly detect the X-Forwarded-Proto sent in by the upstream proxy.

bd808 renamed this task from Cloud VPS MediaWiki-Vagrant root URL should not redirect from HTTP to HTTP to Cloud VPS MediaWiki-Vagrant root URL should not redirect from HTTPS to HTTP.Nov 3 2019, 8:49 PM

Change 547989 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[mediawiki/vagrant@master] apache2: Respect X-Forwarded-Proto when redirecting

https://gerrit.wikimedia.org/r/547989

Change 547989 merged by jenkins-bot:
[mediawiki/vagrant@master] apache2: Respect X-Forwarded-Proto when redirecting

https://gerrit.wikimedia.org/r/547989

bd808 claimed this task.