Page MenuHomePhabricator

Long edit summary/titles/user breaking AMC special pages
Open, LowPublic3 Estimate Story Points

Description

Steps to reproduce

  1. Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=AHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH
  2. Edit the page and add the edit summary "AHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH"
  3. Watch the page
  4. View the history of the page on a mobile browser

Problems:

  • Note the username isnt contained
  1. Now visit Special:Watchlist (or Special:RecentChanges)

Problems:

  • Note the username isnt contained
  • Note the title is not contained
  • Note the edit summary is not contained.

Expected

  • page should render normally

Observed

  • Width is broken:

Developer notes

We can solve this by limiting the width and showing an ellipsis or breaking long words on multiple lines.
In the case of the edit summary we can either break the word or limit the size of the edit summary and showing an ellipsis, but given the presentation of the title and username the ellipsis seems the best option.

acceptance criteria

After talking to Alex..

  • Use ellipsis on title and username
  • Break long words on watchlist view

qa steps

  1. Edit summaries
  2. Look at edit summaries on https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=AHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH&action=historywrappppppppppppppppppppppppppppppppiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiing history page and create a new edit with a long word (using one of the existing sumarries as examples. When editing the page will be added to your watchlist
  3. Check the history page on a mobile device
  4. Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist?hidecategorization=1&hideWikibase=1&limit=250&days=3&urlversion=2 and make sure the words are wrapping.
  5. Check the same on Special:RecentChanges, User:Contributions/<yourname>.

Username

-Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=AHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH&action=history

  • Confirm username is truncated with a ...
  • Edit the page
  • Visit Special:Watchlist and confirm the title is truncated with a ...

Details

Event Timeline

ovasileva created this task.Nov 4 2019, 9:55 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptNov 4 2019, 9:55 AM
Jdlrobson renamed this task from Long edit summary breaking AMC special pages to Long edit summary/titles/user breaking AMC special pages.Nov 4 2019, 10:02 PM
Jdlrobson assigned this task to alexhollender.
Jdlrobson updated the task description. (Show Details)

Change 548537 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] POC: Long edit summary/titles/user breaking AMC special pages

https://gerrit.wikimedia.org/r/548537

Jdlrobson added subscribers: Volker_E, Jdlrobson.

Above is a POC. @alexhollender / @Volker_E this needs design input (see open questions in description). Please move back to needs analysis when you're done.

Is forced line break or overflow ellipsis better for summary/titles? How are we dealing with information “loss” when ellipsis is used?

Change 548537 abandoned by Jdlrobson:
POC: Long edit summary/titles/user breaking AMC special pages

Reason:
If using please fold in https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/ /548536/1

https://gerrit.wikimedia.org/r/548537

alexhollender added a comment.EditedNov 5 2019, 5:42 PM

@Jdlrobson where are you seeing this? Here is what it looks like for me on History:

iOS / SafariMac / ChromeAndroid / Chrome
Masumrezarock100 added a comment.EditedNov 5 2019, 6:22 PM

@Jdlrobson where are you seeing this? Here is what it looks like for me on Watchlist:

iOS / SafariMac / ChromeAndroid / Chrome

That's definitely not the Watchlist page. :-)

That's definitely not the Watchlist page. :-)

Whoops, good catch. Just updated the comment to say "History" instead of "Watchlist".

Masumrezarock100 added a comment.EditedNov 5 2019, 6:33 PM

As @alexhollender's screenshots show, words in big summaries start on a new line in the history page, just like how it is in non-AMC mode. But the problem is with some other Special pages (Watchlist, contributions etc). So far I have tested it with Watchlist and Contributions, and the width is broken in both of these pages. I've not yet tested it with RecentChanges and there could be other special pages with this problem.

Contributions (as you can see the width is broken)Watchlist (same broken design)History page (looks good)
Jdlrobson updated the task description. (Show Details)Nov 5 2019, 7:20 PM

I've added better replication steps. There is one issue with the history page

alexhollender removed alexhollender as the assignee of this task.Nov 6 2019, 6:04 PM
alexhollender added a subscriber: alexhollender.
Jdlrobson added a subscriber: Edtadros.

I've added better replication steps. There is one issue with the history page

Yeah, it seems the new letters in username in History page don't start on a new line if I resize the window too much.

ovasileva lowered the priority of this task from High to Medium.Dec 4 2019, 5:43 PM

Ping @alexhollender any idea what to do here? Need some help answering the open questions!

alexhollender removed alexhollender as the assignee of this task.Dec 16 2019, 6:09 PM
ovasileva set the point value for this task to 3.Dec 18 2019, 5:17 PM

Change 548537 restored by Phuedx:
POC: Long edit summary/titles/user breaking AMC special pages

https://gerrit.wikimedia.org/r/548537

JTannerWMF added a subscriber: JTannerWMF.

Volker is planning to work on this this week.

phuedx removed a subscriber: phuedx.Thu, Feb 20, 9:28 AM

After a quick look, this should probably be fixed upstream in “ActionFieldLayout aligned inline”. Not convinced that ellipsis is a good solution anywhere as it might result in an extra click. I'd defer to showing always full contents (title of this label) and rather oblige more scrolling to the user instead of clicking and wait time for loading corresponding page.
Showing here the example given in the description on iPhone 6/7/8 (375px, not even 320px our minimum requirement)

If we do ellipsis we hide too much IMHO.

With word-break:

Change 573620 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] FieldLayout: Break overlong words in labels of inline FieldLayouts

https://gerrit.wikimedia.org/r/573620

Change 573620 merged by jenkins-bot:
[oojs/ui@master] FieldLayout: Break overlong words in labels of inline FieldLayouts

https://gerrit.wikimedia.org/r/573620

Jdlrobson reassigned this task from Volker_E to Edtadros.Mon, Feb 24, 7:24 PM

Blocked n OOUI release?

ovasileva lowered the priority of this task from Medium to Low.Tue, Feb 25, 4:29 PM

Change 575115 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.37.0

https://gerrit.wikimedia.org/r/575115

Change 575115 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.37.0

https://gerrit.wikimedia.org/r/575115