- The ALTER TABLES to run: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikimediaEditorTasks/+/master/sql/alter-wikimedia_editor_tasks_counts.sql
- Where to run those changes: extension1, DB: wikishared
- When to run those changes: ASAP; code using the new column is feature-flagged
- If the schema change is backwards compatible: compatible with the current code deployed.
- If the schema change has been tested already on some of the test/beta wikis. Usually, as a last test, change should be applied to testwiki first: Tested and works well on Beta.
- If it involves new columns or tables, if the data should be made available on the labs replicas. Similar question if it involves deletion of data previously available on labs. The table is being replicated to labs but is not yet exposed by a view. (See T218302#5080997 for the most recent update.)
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • scblr | T228845 [EPIC] Suggested edits V3 | |||
| Resolved | • Sharvaniharan | T234955 API for reverts for SE v3 | |||
| Resolved | jcrespo | T237264 Schema change for T234955 - add column wetc_revert_count to wikimedia_editor_tasks_counts |
Event Timeline
Comment Actions
Unless I am wrong, this seems like a single change to a single DB in just a few servers, so it could be run right away. Please let us know when you test it and should be a fast schema change for production.
Comment Actions
Thanks @jcrespo for the ping. I actually tested this yesterday on the Beta Cluster and it's working well.
Comment Actions
@Mholloway I now understood the other ticket- it is a single, common table. I thought it was one table per wiki. Your comment now makes sense.
I am running this right away- this clear ticket and the fact it is a small change on a small table on a single location makes it trivial. Thank you!
Comment Actions
root@cumin1001:~/software/dbtools$ ./section x1 | while read instance; do echo; echo $instance; mysql.py -h $instance wikishared -e "SHOW CREATE TABLE wikimedia_editor_tasks_counts\G" | grep wetc_revert_count; done dbstore1005:3320 `wetc_revert_count` int(10) unsigned NOT NULL DEFAULT '0', db2131 `wetc_revert_count` int(10) unsigned NOT NULL DEFAULT '0', db2115 `wetc_revert_count` int(10) unsigned NOT NULL DEFAULT '0', db2101:3320 `wetc_revert_count` int(10) unsigned NOT NULL DEFAULT '0', db1140:3320 `wetc_revert_count` int(10) unsigned NOT NULL DEFAULT '0', db1137 `wetc_revert_count` int(10) unsigned NOT NULL DEFAULT '0', db1127 `wetc_revert_count` int(10) unsigned NOT NULL DEFAULT '0', db2096 `wetc_revert_count` int(10) unsigned NOT NULL DEFAULT '0', db1120 `wetc_revert_count` int(10) unsigned NOT NULL DEFAULT '0',
I've checked, out of caution, if the table exist elsewhere and I have not found it:
root@s3-master.eqiad.wmnet[(none)]> select * FROM information_schema.tables where table_name='wikimedia_editor_tasks_counts'; Empty set (0.04 sec) root@db1120.eqiad.wmnet[wikishared]> select * FROM information_schema.tables where table_name='wikimedia_editor_tasks_counts'; +---------------+--------------+-------------------------------+------------+--------+---------+------------+----------- | TABLE_CATALOG | TABLE_SCHEMA | TABLE_NAME | TABLE_TYPE | ENGINE | VERSION | ROW_FORMAT | TABLE_ROWS +---------------+--------------+-------------------------------+------------+--------+---------+------------+----------- | def | wikishared | wikimedia_editor_tasks_counts | BASE TABLE | InnoDB | 10 | Compact | 16513 +---------------+--------------+-------------------------------+------------+--------+---------+------------+----------- 1 row in set (0.04 sec)
Please confirm the change is correct and resolve. :-)