Page MenuHomePhabricator
Create Task
Maniphest T237289

Vertical alignment regressions in desktop link contexts
Closed, ResolvedPublic
Actions

Description

image.png (218×427 px, 22 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (a6ef2cc7d)mediawiki/extensions/VisualEditormaster+1 -1
Tweak alignment of frameless button in desktop context furtherVisualEditor/VisualEditormaster+8 -7
Update VE core submodule to master (8cba52aa6)mediawiki/extensions/VisualEditormaster+1 -1
Fix alignment of frameless button in desktop contextVisualEditor/VisualEditormaster+1 -10
Fix vertical alignment in LinkContextItemVisualEditor/VisualEditormaster+3 -2
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Nov 4 2019, 5:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2019, 5:59 PM
Esanders added a comment.Nov 4 2019, 6:30 PM

Bisect unsurprisingly blames an OOUI update. v0.35.1 :)

Esanders added subscribers: Volker_E, matmarex.Nov 4 2019, 6:34 PM

cc @Volker_E @matmarex

gerritbot added a comment.Nov 4 2019, 7:37 PM

Change 548467 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Fix alignment of frameless button in desktop context

https://gerrit.wikimedia.org/r/548467

gerritbot added a project: Patch-For-Review.Nov 4 2019, 7:37 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Nov 4 2019, 7:38 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Nov 4 2019, 7:40 PM

Change 548469 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[VisualEditor/VisualEditor@master] Fix vertical alignment in LinkContextItem

https://gerrit.wikimedia.org/r/548469

matmarex added a comment.Nov 4 2019, 7:40 PM

Seems to be caused by the addition of min-height in https://gerrit.wikimedia.org/r/c/oojs/ui/+/514970/19/src/themes/wikimediaui/elements.less , removing that rule fixes it.

Esanders added a comment.Nov 4 2019, 7:47 PM

It does, but the height addition is useful in increasing the click target, so I added negative margin instead.

Volker_E added a comment.Nov 4 2019, 7:51 PM

This ^!

gerritbot added a comment.Nov 4 2019, 7:51 PM

Change 548469 abandoned by VolkerE:
Fix vertical alignment in LinkContextItem

Reason:
for I59a4d1a4e6ac18e60916b31855634ba552bea9c8

https://gerrit.wikimedia.org/r/548469

gerritbot added a comment.Nov 4 2019, 8:12 PM

Change 548467 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Fix alignment of frameless button in desktop context

https://gerrit.wikimedia.org/r/548467

gerritbot added a comment.Nov 4 2019, 8:13 PM

Change 548484 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (5f0d866a0)

https://gerrit.wikimedia.org/r/548484

gerritbot added a comment.Nov 4 2019, 8:15 PM

Change 548485 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Tweak alignment of frameless button in desktop context further

https://gerrit.wikimedia.org/r/548485

gerritbot added a comment.Nov 6 2019, 3:24 PM

Change 548484 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8cba52aa6)

https://gerrit.wikimedia.org/r/548484

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 6 2019, 4:00 PM
gerritbot added a comment.Nov 6 2019, 6:12 PM

Change 548485 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Tweak alignment of frameless button in desktop context further

https://gerrit.wikimedia.org/r/548485

Maintenance_bot removed a project: Patch-For-Review.Nov 6 2019, 7:10 PM
gerritbot added a comment.Nov 7 2019, 10:11 PM

Change 549651 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a6ef2cc7d)

https://gerrit.wikimedia.org/r/549651

gerritbot added a project: Patch-For-Review.Nov 7 2019, 10:11 PM
gerritbot added a comment.Nov 7 2019, 10:27 PM

Change 549651 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a6ef2cc7d)

https://gerrit.wikimedia.org/r/549651

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2019, 11:10 PM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Nov 8 2019, 2:10 AM
Ryasmeen added a project: Verified.Nov 12 2019, 6:49 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
ppelberg closed this task as Resolved.Dec 24 2019, 7:15 PM
ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits