Page MenuHomePhabricator
Create Task
Maniphest T237298

CheckUser 2.0: Display the data fetched on special page (preliminary check)
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Based on what's submitted via the form, display the search results on the special page.

Give each data field a CSS class when the table is output. Then, the highlights are quite easy with CSS.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[WIP alternative] Display preliminary results in a table in Special:Investigatemediawiki/extensions/CheckUsermaster+316 -5
Display preliminary results in a table in Special:Investigatemediawiki/extensions/CheckUsermaster+279 -5
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT139810 RFC: Overhaul the CheckUser extension
 ResolvedNiharikaT236225 [Epic] CheckUser 2.0 Improvements
ResolvedNiharikaT237039 [Epic] CheckUser 2.0: Preliminary check
 ResolvedTchandersT237299 CU 2.0: Sticky highlighting in Preliminary check and Compare tabs
 ResolvedNiharikaT237593 [Epic] CheckUser 2.0: Compare
 ResolvedTchandersT237300 CU 2.0: Sorting in the Compare tab
 ResolvedTchandersT237298 CheckUser 2.0: Display the data fetched on special page (preliminary check)
 ResolveddmazaT237296 CheckUser 2.0: Create service and methods for new CU extension
 ResolveddbarrattT239682 CU 2.0: Namespace Service Name
 ResolvedTchandersT237034 CheckUser 2.0: Input form
 ResolvedTchandersT236981 CheckUser 2.0: Create a new Special page in CheckUser for the redesigned version
 ResolvedTchandersT239936 Enable Special:Investigate on testwiki
 ResolvedTchandersT238240 Allow HTMLUsersMultiselectField to set max limit on number of selected items
 ResolvedTchandersT238277 Allow UsersMultiselectWidget to show valid IP addresses and ranges in the autocomplete menu
 ResolvedTchandersT238318 Let UsersMultiselectWidget disallow arbitrary input
 ResolvedTchandersT243075 TagMultiselectWidget clears input before adding tag, causing validation failure in downstream widgets
 ResolvedTchandersT243077 TagMultiselectWidget performs unnecessary validity check in change handler
 ResolvedTchandersT243643 Set selected MenuTagMultiselectWidget items as options in the constructor
 ResolvedTchandersT238827 Reorganise preliminary check service for paginated results

Event Timeline

• aezell created this task.Nov 4 2019, 6:35 PM
Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptNov 4 2019, 6:35 PM
Niharika triaged this task as Medium priority.Nov 4 2019, 10:21 PM
Niharika removed a project: Epic.
Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.Nov 4 2019, 10:24 PM
Niharika set the point value for this task to 3.Nov 5 2019, 7:57 PM
Niharika renamed this task from Show CU data on new special page to CheckUser 2.0: Show CU data on new special page.Nov 5 2019, 8:05 PM
Niharika renamed this task from CheckUser 2.0: Show CU data on new special page to CheckUser 2.0: Display the data fetched on special page.Nov 5 2019, 8:19 PM
Niharika moved this task from Triage/To be Estimated to The Letter Song on the Anti-Harassment-Team board.Nov 7 2019, 10:15 PM
Niharika edited projects, added Anti-Harassment-Team (The Letter Song); removed Anti-Harassment-Team.
dbarratt added a subtask: T237296: CheckUser 2.0: Create service and methods for new CU extension.Nov 7 2019, 10:18 PM
dbarratt added a subtask: T237034: CheckUser 2.0: Input form.
dbarratt added a parent task: T237299: CU 2.0: Sticky highlighting in Preliminary check and Compare tabs.Nov 7 2019, 10:22 PM
dbarratt added a parent task: T237300: CU 2.0: Sorting in the Compare tab.
Tchanders claimed this task.Nov 18 2019, 7:48 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.
gerritbot added a comment.Nov 21 2019, 2:37 PM

Change 552269 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] WIP Display preliminary results in a table in Special:Investigate

https://gerrit.wikimedia.org/r/552269

gerritbot added a project: Patch-For-Review.Nov 21 2019, 2:37 PM
Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Nov 21 2019, 4:27 PM
Niharika renamed this task from CheckUser 2.0: Display the data fetched on special page to CheckUser 2.0: Display the data fetched on special page (preliminary check).Nov 21 2019, 5:51 PM
dom_walden mentioned this in T237034: CheckUser 2.0: Input form.Nov 27 2019, 11:27 AM
Tchanders reassigned this task from Tchanders to dbarratt.Dec 5 2019, 5:30 PM
Tchanders subscribed.
dbarratt removed dbarratt as the assignee of this task.Dec 6 2019, 10:24 PM
dbarratt subscribed.
dom_walden mentioned this in T237296: CheckUser 2.0: Create service and methods for new CU extension.Dec 12 2019, 5:46 PM
Niharika closed subtask T237296: CheckUser 2.0: Create service and methods for new CU extension as Resolved.Dec 17 2019, 10:11 PM
dbarratt claimed this task.Jan 2 2020, 4:34 PM
Tchanders claimed this task.Jan 6 2020, 1:34 PM
gerritbot added a comment.Jan 9 2020, 3:20 PM

Change 563194 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] [WIP alternative] Display preliminary results in a table in Special:Investigate

https://gerrit.wikimedia.org/r/563194

gerritbot added a comment.Jan 15 2020, 7:44 PM

Change 552269 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Display preliminary results in a table in Special:Investigate

https://gerrit.wikimedia.org/r/552269

Niharika added a comment.Jan 15 2020, 9:03 PM
In T237298#5807000, @gerritbot wrote:

Change 552269 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Display preliminary results in a table in Special:Investigate

https://gerrit.wikimedia.org/r/552269

🎉

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 15 2020, 10:15 PM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (The Letter Song) board.Jan 23 2020, 7:48 PM
Tchanders mentioned this in T238827: Reorganise preliminary check service for paginated results.Jan 23 2020, 7:50 PM
Tchanders added a subscriber: dom_walden.

@dom_walden It probably makes more sense to test T238827, T237298 and T239680 together.

Tchanders mentioned this in T239680: CU 2.0: Persist the form state.Feb 7 2020, 1:25 AM
gerritbot added a comment.Feb 10 2020, 2:58 AM

Change 563194 abandoned by Tchanders:
[WIP alternative] Display preliminary results in a table in Special:Investigate

Reason:
Uploaded for illustration

https://gerrit.wikimedia.org/r/563194

Maintenance_bot removed a project: Patch-For-Review.Feb 10 2020, 3:10 AM
Niharika closed subtask T237034: CheckUser 2.0: Input form as Resolved.Feb 13 2020, 7:14 PM
dom_walden moved this task from QA/Testing 🐞 to Done (2019-20: Q3) on the Anti-Harassment-Team (The Letter Song) board.Feb 19 2020, 3:31 PM

I think I have tested this before, but with all the recent changes I guess it is as well to retest it.

Comparing the results of Preliminary Check with Special:CentralAuth for a few different users. I did not see any discrepancies in the "Date attached", "Wiki", "Edits", blocked "Status", or "Groups".

Environment: Local vagrant MediaWiki 1.35.0-alpha (b7562e5), CheckUser 2.5 (bb62ea2) 07:23, 19 February 2020.

Tchanders closed this task as Resolved.Feb 19 2020, 3:41 PM
Tchanders closed subtask T238827: Reorganise preliminary check service for paginated results as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits