Page MenuHomePhabricator

CU 2.0: Sticky highlighting in Preliminary check and Compare tabs
Open, MediumPublic5 Estimate Story Points

Description

Goal

In the table of search results from the CU special page, if a user clicks on a highlighted data field, the other highlight items should stay highlighted as the mouse moves.

Mock

https://prtksxna.github.io/wmf-cu-prototype/compare.html

An unhighlighted row
When a row is highlighted, the cell with the mouseover gets the following buttons
Clicking the pin will highlight the button
Notes
  • We wont be putting the funnel button right now
  • There might be some changes to just the buttons later (size, icon etc)
  • Once the user moves their mouse from the cell the buttons go away, but the highlight remains
  • Hovering on the cell again brings back the button, and that is how you unpin it
  • For the above example, all Chrome 65 cells would have had the pin highlighted once it was selected. This way the user can unpin from any highlighted row and doesn't have to find the original row/cell they highlighted from
  • All other highlighting stops if a highlight has been pinned (we might want to change this in the future?)
Acceptance criteria

Things that highlighting works for:

  1. Preliminary check tab
    • Wiki
    • Date attached (Exact matches)
  2. Compare tab
    • IP
    • User-agent

Related Objects

Event Timeline

aezell created this task.Nov 4 2019, 6:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2019, 6:36 PM
Niharika triaged this task as Medium priority.Nov 4 2019, 10:21 PM
Niharika removed a project: Epic.
Niharika added a subscriber: Prtksxna.

This ticket would need a design from @Prtksxna before we can move forward. This is talking about the 'sticky-highlight' that we talked about previously.

Niharika renamed this task from Allow the highlight to be "locked" if a user clicks to CU 2.0: Sticky highlighting in Preliminary check and Compare tabs.Nov 20 2019, 8:09 PM
Niharika assigned this task to Prtksxna.
Niharika updated the task description. (Show Details)

@Prtksxna assigning this to you for the mock and design specs.

Prtksxna updated the task description. (Show Details)Nov 21 2019, 1:21 PM

@Prtksxna We also talked about the sticky highlights showing up in the filters at one point. Are you still planning to add that in?

@Prtksxna We also talked about the sticky highlights showing up in the filters at one point. Are you still planning to add that in?

The way I am thinking about this is — you highlight rows that you're interested in, and filter out rows in which you aren't. By that understanding sticky highlights should never become filters. What do you think?


Per @dbarratt's suggestion we do want to provide a way to efficiently add filters through the data itself. For this I've added a filter icon (maybe a trash icon would be better suited):

Hovering over it will reveal which rows will get removed if this filter is applied:

Finally, clicking it should add the data point to the Filter form and remove the relevant rows.

Should we create a new ticket for this behavior, @Niharika?

@Prtksxna We also talked about the sticky highlights showing up in the filters at one point. Are you still planning to add that in?

The way I am thinking about this is — you highlight rows that you're interested in, and filter out rows in which you aren't. By that understanding sticky highlights should never become filters. What do you think?

Makes sense.


Per @dbarratt's suggestion we do want to provide a way to efficiently add filters through the data itself. For this I've added a filter icon (maybe a trash icon would be better suited):


Hovering over it will reveal which rows will get removed if this filter is applied:

Finally, clicking it should add the data point to the Filter form and remove the relevant rows.
Should we create a new ticket for this behavior, @Niharika?

Yep, that would be great. :)

Niharika updated the task description. (Show Details)Dec 10 2019, 7:46 PM
Niharika set the point value for this task to 5.Dec 10 2019, 8:02 PM
Niharika removed Prtksxna as the assignee of this task.Fri, Jan 17, 8:05 PM