Page MenuHomePhabricator

CU 2.0: Sorting in the Compare tab
Open, MediumPublic3 Estimate Story Points

Description

Goal

Users should be able to sort the displayed data in the Compare tab to be able to find patterns more easily.

Acceptance criteria
  • The frontend for the sorting was part of T238782: CU 2.0: Display data in the Compare tab. Sorting can be done by username, UA or IP address (treat it like a string?).
  • By clicking the column header, the results will sort.
  • The sort will not work across all paginated tabs.
    • We talked about this and technically it can only be sorted within the same page. We need a unique column to sort across multiple paginated tabs which we can't do. T244579
  • Loading animation while the results re-load will be same as on recent changes (https://codepen.io/Volker_E/pen/yqNXMe)

Related Objects

Event Timeline

aezell created this task.Nov 4 2019, 6:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2019, 6:37 PM
Niharika triaged this task as Medium priority.Nov 4 2019, 10:21 PM
Niharika removed a project: Epic.
Niharika renamed this task from Add filtering, sorting, pagination(?) to the data table to CU 2.0: Sorting in the Compare tab.Nov 20 2019, 7:41 PM
Niharika updated the task description. (Show Details)
Niharika set the point value for this task to 3.Nov 21 2019, 5:35 PM
Demian added a subscriber: Demian.Dec 4 2019, 9:34 PM

A few thoughts on the implementation:

  1. Less than ca. 100 results should all be sent to the client and sorted client-side for lower latency.
  2. More results could be sorted and paginated server-side. The second page is visited less often, so this would save loading time and bandwidth.
  3. Result pages should be loaded only once and cached in the client. After all pages are loaded (visited), sorting can be done client-side.
  4. The pagination state is: usernames, CU log unique key, CU log timestamp, ordering, starting index, count. Details: T239680#5713699
Niharika updated the task description. (Show Details)Feb 6 2020, 7:25 PM
dbarratt updated the task description. (Show Details)Feb 13 2020, 6:20 PM
dbarratt updated the task description. (Show Details)