Don't allow thanking system users
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	DannyS712
	Nov 5 2019, 7:11 AM

Description

See, eg, https://en.wikivoyage.org/wiki/Special:Log?type=thanks&page=User%3AAbuse+filter

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+33 -5	Split out separate `User::isSystemUser` method.
	mediawiki/extensions/Thanks	master	+1 -1	Don't allow thanking system users

Customize query in gerrit

Related Objects

Mentioned In: T239526: Note that a user is a system user on Special:Userrights
T212720: System users should be in a dedicated user group

Event Timeline

DannyS712 created this task.Nov 5 2019, 7:11 AM

Restricted Application added projects: Growth-Team, User-DannyS712. · View Herald TranscriptNov 5 2019, 7:11 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Nice catch!

Masumrezarock100 changed the subtype of this task from "Task" to "Bug Report".Nov 5 2019, 7:34 AM

Change 548919 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Split out separate User::isSystemUser method.

https://gerrit.wikimedia.org/r/548919

gerritbot added a project: Patch-For-Review.Nov 5 2019, 10:42 PM

Change 548921 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Thanks@master] Don't allow thanking system users

https://gerrit.wikimedia.org/r/548921

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Nov 5 2019, 10:50 PM

DannyS712 mentioned this in T212720: System users should be in a dedicated user group.Nov 13 2019, 8:45 PM

JJMC89 moved this task from Backlog to Other on the MediaWiki-User-management board.Nov 22 2019, 11:19 PM

Change 548919 merged by jenkins-bot:
[mediawiki/core@master] Split out separate User::isSystemUser method.

https://gerrit.wikimedia.org/r/548919

Change 548921 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Don't allow thanking system users

https://gerrit.wikimedia.org/r/548921

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 25 2019, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 26 2019, 11:44 AM

DannyS712 closed this task as Resolved.Nov 28 2019, 7:30 AM

DannyS712 mentioned this in T239526: Note that a user is a system user on Special:Userrights.Dec 1 2019, 6:59 AM