Page MenuHomePhabricator

Fix load times for language variant FST files
Open, HighPublic

Description

I created a phab task to track this known work that needs to happen soon.

Event Timeline

ssastry triaged this task as High priority.Nov 5 2019, 4:45 PM
ssastry created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2019, 4:45 PM
ssastry moved this task from Backlog to Performance on the Parsoid-PHP board.Nov 5 2019, 4:45 PM

This should be mostly addressed by I58d54dec51e8a4da0d1f0ba68144a2dd0cac6235 / 9d17caeca8310a748c956a6c3f8efbf3c9073d49 in the langconv library. That still does a file_get_contents() to load the FST; we could compile these into PHP files with a string constant to allow caching the data across PHP instances. Waiting for initial performance metrics to determine if that additional step is necessary (or effective: it may be that APC refuses to cache such large class files).