Page MenuHomePhabricator
Create Task
Maniphest T237462

Port Parsoid/JS JSON extension to Parsoid/PHP
Closed, ResolvedPublic
Actions

Description

We never ported this code. But, this is not a blocker to live traffic deployment.

Details

SubjectRepoBranchLines +/-
Fixed casing in content model keymediawiki/services/parsoidmaster+2 -2
Have json extention subclass contentModelHandlerExtensionmediawiki/services/parsoidmaster+26 -24
Porting JSON extension part 2 adapting to use ParsoidAPI interfacemediawiki/services/parsoidmaster+33 -35
JSONContentModelHandler portingmediawiki/services/parsoidmaster+427 -240
Customize query in gerrit

Event Timeline

ssastry triaged this task as Medium priority.Nov 5 2019, 9:10 PM
ssastry created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2019, 9:10 PM
ssastry moved this task from Backlog to Porting on the Parsoid-PHP board.Nov 5 2019, 9:10 PM
Reedy updated the task description. (Show Details)Jan 21 2020, 6:38 PM
Sbailey claimed this task.Jan 21 2020, 7:56 PM
gerritbot added a comment.Feb 6 2020, 9:16 PM

Change 570725 had a related patch set uploaded (by Sbailey; owner: Sbailey):
[mediawiki/services/parsoid@master] WIP JSONContentModelHandler porting

https://gerrit.wikimedia.org/r/570725

gerritbot added a project: Patch-For-Review.Feb 6 2020, 9:16 PM
gerritbot added a comment.Feb 27 2020, 7:15 PM

Change 575332 had a related patch set uploaded (by Sbailey; owner: Sbailey):
[mediawiki/services/parsoid@master] Porting JSON extension part 2 adapting to use ParsoidAPI interface

https://gerrit.wikimedia.org/r/575332

gerritbot added a comment.Feb 28 2020, 6:16 PM

Change 570725 merged by jenkins-bot:
[mediawiki/services/parsoid@master] JSONContentModelHandler porting

https://gerrit.wikimedia.org/r/570725

gerritbot added a comment.Feb 28 2020, 6:23 PM

Change 575592 had a related patch set uploaded (by Sbailey; owner: Sbailey):
[mediawiki/services/parsoid@master] Porting JSON extension part 2, using ParsoidAPI interface

https://gerrit.wikimedia.org/r/575592

gerritbot added a comment.Feb 28 2020, 6:24 PM

Change 575332 abandoned by Sbailey:
Porting JSON extension part 2 adapting to use ParsoidAPI interface

https://gerrit.wikimedia.org/r/575332

ssastry closed this task as Resolved.Feb 28 2020, 9:16 PM
gerritbot added a comment.Mar 4 2020, 12:53 AM

Change 576487 had a related patch set uploaded (by Sbailey; owner: Sbailey):
[mediawiki/services/parsoid@master] Fixed casing in content model key

https://gerrit.wikimedia.org/r/576487

gerritbot added a comment.Mar 4 2020, 1:13 AM

Change 575592 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Have json extention subclass contentModelHandlerExtension

https://gerrit.wikimedia.org/r/575592

gerritbot added a comment.Mar 4 2020, 1:14 AM

Change 576487 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Fixed casing in content model key

https://gerrit.wikimedia.org/r/576487

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2020, 2:10 AM
Sbailey added a comment.Mar 4 2020, 3:51 PM

JSON extension ported from JS to PHP complete.
1 Port-fixme is still present due to a dependence on addMetaData that is not avaialble yet to extensions.
Part of the addMetaData functionality was duplicated in the extension in the mean time.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL