Page MenuHomePhabricator
Create Task
Maniphest T237483

Newcomer Tasks: make text extracts display wrapped text
Closed, ResolvedPublic
Actions

Assigned To
MMiller_WMF
Authored By
Etonkovidova
Nov 5 2019, 11:51 PM
Project Tags
Referenced Files
F31101077: Screen Shot 2019-11-19 at 8.33.29 AM.png
Nov 19 2019, 1:52 PM
F31101074: Screen Shot 2019-11-18 at 9.16.42 PM.png
Nov 19 2019, 1:52 PM
F31095892: Screen Shot 2019-11-17 at 2.28.08 PM.png
Nov 17 2019, 8:03 PM
F31095870: Screen Shot 2019-11-17 at 2.24.23 PM.png
Nov 17 2019, 8:03 PM
F31076074: image.png
Nov 14 2019, 6:22 PM
F31064930: image.png
Nov 14 2019, 12:51 AM
F31064392: image.png
Nov 13 2019, 4:27 PM
F31018930: image.png
Nov 5 2019, 11:53 PM
View All 9 Files
Subscribers
Aklapper
Catrope
Etonkovidova
kostajh
MMiller_WMF
PPham
RHo
Tgr

Description

Currently, only one line of text is shown in suggested article preview cards:

image.png (383×363 px, 17 KB)

The text extracts should look as in the following mockup. Only instead of ellipsis at the end of the text, the text should fade.

image (1).png (269×292 px, 69 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
SuggestedEditCardWidget: Make extract fade out at the endCatropemediawiki/extensions/GrowthExperimentsmaster+25 -1
SuggestedEditCardWidget: Restrict card title to one lineCatropemediawiki/extensions/GrowthExperimentsmaster+6 -0
Suggested Edits: Make extract text span up to 4 linesKosta Harlanmediawiki/extensions/GrowthExperimentsmaster+2 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Nov 5 2019, 11:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2019, 11:51 PM
MMiller_WMF renamed this task from Newcomer Tasks - make text extracts display wrapped text to Newcomer Tasks: make text extracts display wrapped text .Nov 5 2019, 11:52 PM
MMiller_WMF edited projects, added: Growth-Team (Sprint 0 (Growth Team)); removed: Growth-Team.
MMiller_WMF updated the task description. (Show Details)
MMiller_WMF added a parent task: T227728: [EPIC] Growth: Newcomer tasks 1.0.
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh claimed this task.Nov 6 2019, 9:22 AM
kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Nov 6 2019, 10:58 AM

Change 549063 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Make extract text span up to 4 lines

https://gerrit.wikimedia.org/r/549063

gerritbot added a project: Patch-For-Review.Nov 6 2019, 10:58 AM
gerritbot added a comment.Nov 7 2019, 1:51 AM

Change 549063 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Make extract text span up to 4 lines

https://gerrit.wikimedia.org/r/549063

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 7 2019, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 7 2019, 2:10 AM
kostajh removed kostajh as the assignee of this task.Nov 7 2019, 2:34 PM
kostajh moved this task from In Progress to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh subscribed.

Moving back to ready for dev for the text fade bit.

MMiller_WMF added a subscriber: Catrope.Nov 13 2019, 4:27 PM

@Catrope -- as you work on this, I want to make sure that production will not include parentheticals and templates in the text extracts, the way we see on beta right now:

image.png (439×637 px, 46 KB)

Right now we see templates, phonetic pronunciation, etc.

MMiller_WMF added a subscriber: PPham.EditedNov 14 2019, 12:51 AM

@Catrope -- today, @PPham noticed that long titles can push the article text preview off the card:

image.png (418×695 px, 61 KB)

Here's a screenshot where the pageviews are pushed off the card:

image.png (424×618 px, 48 KB)

gerritbot added a comment.Nov 14 2019, 10:36 PM

Change 550964 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEditCardWidget: Make extract fade out at the end

https://gerrit.wikimedia.org/r/550964

gerritbot added a project: Patch-For-Review.Nov 14 2019, 10:36 PM
gerritbot added a comment.Nov 14 2019, 10:52 PM

Change 550967 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEditCardWidget: Restrict card title to one line

https://gerrit.wikimedia.org/r/550967

Catrope moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 14 2019, 10:52 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 14 2019, 11:08 PM
gerritbot added a comment.Nov 14 2019, 11:20 PM

Change 550964 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] SuggestedEditCardWidget: Make extract fade out at the end

https://gerrit.wikimedia.org/r/550964

gerritbot added a comment.Nov 14 2019, 11:20 PM

Change 550967 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] SuggestedEditCardWidget: Restrict card title to one line

https://gerrit.wikimedia.org/r/550967

Maintenance_bot removed a project: Patch-For-Review.Nov 15 2019, 12:10 AM
MMiller_WMF mentioned this in T238322: Newcomer tasks: pageview info doesn't fit article card.Nov 15 2019, 1:51 AM
MMiller_WMF mentioned this in T238324: With "Zhroucení budov Světového obchodního centra" article, description goes out of article box at mobile.
MMiller_WMF mentioned this in T238325: Incomplete description of "Codecademy.com" in cswiki.
Etonkovidova moved this task from QA to Design Review on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 17 2019, 8:03 PM

Checked in betalabs (including the following phab tasks - T238322, T238324, T238325). I've added this task to the list of tasks to check in production.

General screenshot (just for intormation):
"Fotbalový stadion Za Lužánkami"

Screen Shot 2019-11-17 at 2.24.23 PM.png (438×445 px, 36 KB)

Note: Sometime only one letter of a word is displayed, but I think it's fine:
Sdružení přátel Jaroslava Foglara

Screen Shot 2019-11-17 at 2.28.08 PM.png (446×606 px, 53 KB)

MMiller_WMF added a subscriber: RHo.Nov 18 2019, 9:32 PM

This looks good to me in beta. @RHo please review!

Etonkovidova added a comment.Nov 19 2019, 1:52 PM

There is still an issue with placing pageviews correctly (as per the comment - https://phabricator.wikimedia.org/T237483#5662244 and T238322).
The examples from production:

Screen Shot 2019-11-18 at 9.16.42 PM.png (452×613 px, 66 KB)
Screen Shot 2019-11-19 at 8.33.29 AM.png (457×629 px, 67 KB)
RHo moved this task from Design Review to Needs PM Review on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 19 2019, 7:50 PM

Moving along as this specific issue is fixed, but I have commented on T238322 regarding pageviews display in @Etonkovidova's previous comment.

MMiller_WMF added a comment.Nov 19 2019, 9:49 PM

This looks good to me. Leaving in this column until we've deployed to users.

PPham added a project: User-PPham.Nov 20 2019, 1:36 AM
PPham moved this task from Backlog to Cần để ý on the User-PPham board.Nov 20 2019, 1:39 AM
MMiller_WMF closed this task as Resolved.Jan 2 2020, 11:40 PM
MMiller_WMF claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits