Page MenuHomePhabricator

Newcomer Tasks: make text extracts display wrapped text
Closed, ResolvedPublic

Description

Currently, only one line of text is shown in suggested article preview cards:

image.png (363×383 px, 17 KB)

The text extracts should look as in the following mockup. Only instead of ellipsis at the end of the text, the text should fade.

image (1).png (292×269 px, 69 KB)

Event Timeline

MMiller_WMF renamed this task from Newcomer Tasks - make text extracts display wrapped text to Newcomer Tasks: make text extracts display wrapped text .Nov 5 2019, 11:52 PM
MMiller_WMF updated the task description. (Show Details)

Change 549063 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Make extract text span up to 4 lines

https://gerrit.wikimedia.org/r/549063

Change 549063 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Make extract text span up to 4 lines

https://gerrit.wikimedia.org/r/549063

kostajh subscribed.

Moving back to ready for dev for the text fade bit.

@Catrope -- as you work on this, I want to make sure that production will not include parentheticals and templates in the text extracts, the way we see on beta right now:

image.png (637×439 px, 46 KB)

Right now we see templates, phonetic pronunciation, etc.

@Catrope -- today, @PPham noticed that long titles can push the article text preview off the card:

image.png (695×418 px, 61 KB)

Here's a screenshot where the pageviews are pushed off the card:

image.png (618×424 px, 48 KB)

Change 550964 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEditCardWidget: Make extract fade out at the end

https://gerrit.wikimedia.org/r/550964

Change 550967 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEditCardWidget: Restrict card title to one line

https://gerrit.wikimedia.org/r/550967

Change 550964 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] SuggestedEditCardWidget: Make extract fade out at the end

https://gerrit.wikimedia.org/r/550964

Change 550967 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] SuggestedEditCardWidget: Restrict card title to one line

https://gerrit.wikimedia.org/r/550967

Checked in betalabs (including the following phab tasks - T238322, T238324, T238325). I've added this task to the list of tasks to check in production.

General screenshot (just for intormation):
"Fotbalový stadion Za Lužánkami"

Screen Shot 2019-11-17 at 2.24.23 PM.png (445×438 px, 36 KB)

Note: Sometime only one letter of a word is displayed, but I think it's fine:
Sdružení přátel Jaroslava Foglara

Screen Shot 2019-11-17 at 2.28.08 PM.png (606×446 px, 53 KB)

This looks good to me in beta. @RHo please review!

There is still an issue with placing pageviews correctly (as per the comment - https://phabricator.wikimedia.org/T237483#5662244 and T238322).
The examples from production:

Screen Shot 2019-11-18 at 9.16.42 PM.png (613×452 px, 66 KB)
Screen Shot 2019-11-19 at 8.33.29 AM.png (629×457 px, 67 KB)

Moving along as this specific issue is fixed, but I have commented on T238322 regarding pageviews display in @Etonkovidova's previous comment.

This looks good to me. Leaving in this column until we've deployed to users.

MMiller_WMF claimed this task.