Page MenuHomePhabricator

Regression: [1.35.0-wmf.5] Classic RC lacks space between "(User creation log)"/"(Move log)"/"(Page translation log)" string and date
Closed, ResolvedPublic

Description

I don't know what happening, but time is not correctly aligned in RC.

There should be space between name of log and time.

QA

Note: If you can't see "user creation log" create a new account in an incognito window to get one to show up.

QA Results

ACStatusDetails
1T237500#5646645
2T237500#5646645
3T237500#5646645

Details

Related Gerrit Patches:

Event Timeline

Restricted Application added a project: Growth-Team. · View Herald TranscriptWed, Nov 6, 7:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

On srwiki is everything OK, why is problem on mediawikiwiki?

On srwiki is everything OK, why is problem on mediawikiwiki?

Different version of MW?

On srwiki is everything OK, why is problem on mediawikiwiki?

Different version of MW?

MW is 1.35.0-wmf.5
srwiki is 1.35.0-wmf.4

Aklapper renamed this task from Incorrect alignment in RC to [1.35.0-wmf.5] Classic RC lacks space between "(User creation log)"/"(Move log)"/"(Page translation log)" string and date.Wed, Nov 6, 9:26 AM
Jdlrobson renamed this task from [1.35.0-wmf.5] Classic RC lacks space between "(User creation log)"/"(Move log)"/"(Page translation log)" string and date to Regression: [1.35.0-wmf.5] Classic RC lacks space between "(User creation log)"/"(Move log)"/"(Page translation log)" string and date.Wed, Nov 6, 4:02 PM

I can't replicate this issue on this url. I'm using the preferences:

  • Group changes by page in recent changes and watchlist

[x ] Use non-JavaScript interface

  • Loads RecentChanges without filters search or highlighting functionality.

Where are you seeing this @Zoranzoki21 - can you provide further replication steps?

In recent changes.

In recent changes.

Sure, I got that part.
Can you see the problem at this URL? https://www.mediawiki.org/w/index.php?title=Special:RecentChanges&limit=250&safemode=1
What preferences do you have enabled?
What browser are you using?

Okay, I got this. I was misunderstanding your bug report. I thought you were talking about a different element on the page.

yup that looks the culprit.

Change 549113 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Semicolon should appear after log entries as well.

https://gerrit.wikimedia.org/r/549113

Sorry for misunderstanding, I saw this only in RC. But thanks for patch, should be ok.

Change 549113 merged by jenkins-bot:
[mediawiki/core@master] Semicolon should appear after log entries as well.

https://gerrit.wikimedia.org/r/549113

Jdlrobson updated the task description. (Show Details)Wed, Nov 6, 6:13 PM

This should be cherry picked right?

Change 549434 had a related patch set uploaded (by Zoranzoki21; owner: Jdlrobson):
[mediawiki/core@wmf/1.35.0-wmf.5] Semicolon should appear after log entries as well.

https://gerrit.wikimedia.org/r/549434

Change 549434 had a related patch set uploaded (by Zoranzoki21; owner: Jdlrobson):
[mediawiki/core@wmf/1.35.0-wmf.5] Semicolon should appear after log entries as well.
https://gerrit.wikimedia.org/r/549434

Scheduled for European Mid-Day SWAT.

Change 549434 abandoned by Zoranzoki21:
Semicolon should appear after log entries as well.

https://gerrit.wikimedia.org/r/549434

Change 549434 restored by Zoranzoki21:
Semicolon should appear after log entries as well.

https://gerrit.wikimedia.org/r/549434

Zoranzoki21 triaged this task as Normal priority.Thu, Nov 7, 10:46 PM

This happens on all wikis.

Zoranzoki21 added a comment.EditedThu, Nov 7, 11:26 PM

Ok, not in beta. It's in master branch.
en.wikipedia.beta.wmflabs.org:

Change 549434 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.5] Semicolon should appear after log entries as well.

https://gerrit.wikimedia.org/r/549434

Mentioned in SAL (#wikimedia-operations) [2019-11-08T00:34:12Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.5/resources/: Semicolon should appear after log entries (T237500) (duration: 00m 53s)

Zoranzoki21 closed this task as Resolved.Fri, Nov 8, 1:04 AM
Zoranzoki21 assigned this task to Jdlrobson.
Zoranzoki21 removed a project: Patch-For-Review.

Test Result

Status: ✅ PASS
OS: Windows 7
Browser: Google Chrome

Test Artifact(s):

QA steps

✅ AC1: Visit https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-rc and under advanced options make sure "Use non-JavaScript interface" is ticked and the others are not.

I tried without this and with this, problem looks as resolved.

✅ AC2: Visit https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&limit=50&days=7&urlversion=2

When I visit page, there is everything correct.

✅ AC3:
Grep for "User creation log" - check there is a semi colon following the text.

With it is everything correct, see

Zoranzoki21 updated the task description. (Show Details)Fri, Nov 8, 1:05 AM

Thank you so much for the QA and the swat @Zoranzoki21

Thank you so much for the QA and the swat @Zoranzoki21

Oh, I did QA correctly? Excellent, thank you too for patch!