Page MenuHomePhabricator
Create Task
Maniphest T237504

Background of Tag filter bleeds outside of its bordered box
Closed, ResolvedPublic
Actions

Description

This has been an issue for a couple of weeks now.
The background of the tag filter widget bleeds out beyond it's bounding border.

Screenshot 2019-11-06 at 09.45.29.png (474×728 px, 46 KB)

The background is on .oo-ui-tagMultiselectWidget.oo-ui-widget-enabled.oo-ui-tagMultiselectWidget-outlined
But the border is on the child: .mw-rcfilters-ui-filterTagMultiselectWidget.oo-ui-widget-enabled .oo-ui-tagMultiselectWidget-handle
this element also has a top margin, and that combination is the cause.

Safari.

Details

SubjectRepoBranchLines +/-
RCFilters: Fix bleeding backgroundmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

TheDJ created this task.Nov 6 2019, 8:48 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 6 2019, 8:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova merged a task: T236221: Recent changes - gray background overflows Active filter area .Nov 6 2019, 10:07 PM
Etonkovidova added subscribers: Etonkovidova, Volker_E, Catrope.
TheDJ added a project: Edit-Review-Improvements-RC-Page.Nov 7 2019, 8:59 AM
gerritbot added a comment.Nov 12 2019, 4:18 PM

Change 550507 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] RCFilters: Fix bleeding background

https://gerrit.wikimedia.org/r/550507

gerritbot added a project: Patch-For-Review.Nov 12 2019, 4:18 PM
gerritbot added a comment.Nov 12 2019, 6:26 PM

Change 550507 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Fix bleeding background

https://gerrit.wikimedia.org/r/550507

matmarex closed this task as Resolved.Nov 12 2019, 6:41 PM
matmarex assigned this task to Volker_E.
Maintenance_bot removed a project: Patch-For-Review.Nov 12 2019, 7:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 13 2019, 12:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL