Page MenuHomePhabricator

Update 'Sent' status to 'Finalized'
Closed, ResolvedPublic

Description

As noted a number of times (e.g. T212948), 'sent' (or 'sent to partner') is becoming a misnomer for the final status of an application on the Library Card platform. Of all our distribution workflows, it really only applies to the EMAIL distribution method. For access codes, proxy, and links, we don't send anything to the partner, and in fact approving an application marks it as 'sent' immediately.

We should rename all strings and variables from 'sent' to 'finalised'. In the EMAIL distribution method case, we could still show users the 'sent to partner' text, and show 'finalized' or simply stick with 'approved' otherwise.

Event Timeline

Samwalton9-WMF renamed this task from Update 'Sent' status to read 'Finalized to Update 'Sent' status to 'Finalized'.Nov 6 2019, 11:27 AM
Samwalton9-WMF triaged this task as Medium priority.
Samwalton9-WMF updated the task description. (Show Details)

Hi Sam,
Can I work on this issue ?

test.jpg (1,920×1,080 px, 959 KB)

In image I have marked sent to partner, do I have to change that status to finalized?

Can I work on this issue ?

Sure!

In image I have marked sent to partner, do I have to change that status to finalized?

That's the idea, yes. Though there might be cases where we still want 'Sent' as the text. Let me get back to you on that one.

Should I change every status to finalized ? If no then tell me that how I can find that, in which case the status has to be change from sent to finalized .

Hi @Yash4357 - we had a quick chat about this and while the original ticket description mentions that we might want to keep Sent in some places, we think we could keep this simple and simply update the text everywhere. Let me first confirm that 'Finalized' is the text we want to go with and I'll give you the go ahead to start working on this :)

Hi Sam,
Did you confirm about the text?

Hi Yash, yes - let's go ahead with keeping 'Sent' in the cases where the application is to a publisher with the EMAIL authorization methods, and 'Finalized' when they have the CODES, PROXY, or LINK methods.

I haven't evaluated how difficult this will be in the codebase - we're just looking to split this out in the UI though, so I'm hopeful this will just be a template/view change. Let me know if this looks like you'd need to change models and/or do something more complex.

Shubh1815 subscribed.

I want to work on this issue. So, I was thinking of overriding the "get_status_display" method, and checking the authorization method of the partner and return the status accordingly. Will that be okay??

Hi @Shubh1815 - @Yash4357 has already worked on this task and raised a pull request, which will soon be reviewed :)

@Yash4357 Just checking in - Your PR has been waiting on changes for a while now - If you need help with it just let us know. If you'd like to release the task to let someone else work on it, that would be okay too!

Sorry, for the inconvenience. I am busy in my Gsoc project. So I will not able to work on this task.

@Shubh1815 If you'd still like to work on this, the task is available again, and I agree with the approach you've described.

Will raise a PR on this soon.

Hey @Samwalton9, I am getting this error after setting up the project, can you help me?

Screenshot from 2021-05-28 14-16-58.png (1,366×768 px, 168 KB)

I am getting this error, when i try to run migrations.

django.db.utils.OperationalError: (1091, "Can't DROP COLUMN `old_tags`; check that it exists")

@Shubh1815 Have you tried clearing out your database and running migrations fresh?