Page MenuHomePhabricator
Create Task
Maniphest T237527

Add notice component
Closed, ResolvedPublic
Actions

Description

Extract IconMessageBox from Termbox and add Notice flavor. Possibly upstream into shared repository.

https://tools-static.wmflabs.org/wikibase-termbox-storybook/?path=/story/iconmessagebox--error

Details

SubjectRepoBranchLines +/-
bridge: adjustments of IconMessageBoxmediawiki/extensions/Wikibasemaster+3 -1
bridge: Add notice componentmediawiki/extensions/Wikibasemaster+158 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Nov 6 2019, 12:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 6 2019, 12:08 PM
Addshore subscribed.Nov 6 2019, 2:35 PM
• Pablo-WMDE moved this task from Incoming to Task overflow on the Wikidata-Bridge board.Nov 6 2019, 3:09 PM
• Matthias_Geisler_WMDE claimed this task.Nov 19 2019, 1:53 PM
• Matthias_Geisler_WMDE edited projects, added Wikidata-Bridge-Sprint-9; removed Wikidata-Bridge.
• Matthias_Geisler_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-9 board.
darthmon_wmde added a project: Wikidata-Bridge-Sprint-10.Nov 20 2019, 9:58 AM
darthmon_wmde moved this task from To do to Doing on the Wikidata-Bridge-Sprint-10 board.
gerritbot added a comment.Nov 22 2019, 2:56 PM

Change 552520 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Add notice component

https://gerrit.wikimedia.org/r/552520

gerritbot added a project: Patch-For-Review.Nov 22 2019, 2:56 PM
• Matthias_Geisler_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-10 board.Nov 22 2019, 2:56 PM
gerritbot added a comment.Nov 26 2019, 12:44 PM

Change 552520 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Add notice component

https://gerrit.wikimedia.org/r/552520

Lucas_Werkmeister_WMDE closed this task as Resolved.Nov 26 2019, 12:54 PM
Lucas_Werkmeister_WMDE reopened this task as Open.
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-10 board.
Lucas_Werkmeister_WMDE moved this task from Done to Verification on the Wikidata-Bridge-Sprint-10 board.
Lucas_Werkmeister_WMDE subscribed.

Actually, let’s put this in verification. Can someone update the storybook? (See T235763 for instructions.)

Michael claimed this task.Nov 26 2019, 1:00 PM
Michael added a subscriber: • Matthias_Geisler_WMDE.
In T237527#5693170, @Lucas_Werkmeister_WMDE wrote:

Actually, let’s put this in verification. Can someone update the storybook? (See T235763 for instructions.)

Can do.

Restricted Application added a project: User-Michael. · View Herald TranscriptNov 26 2019, 1:00 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 26 2019, 1:00 PM
Stashbot added a comment.Nov 26 2019, 1:04 PM

Mentioned in SAL (#wikimedia-cloud) [2019-11-26T13:04:36Z] <wm-bot> <migr> npm run build-storybook && tar -C storybook-static -c . | ssh toolforge sudo -i -u tools.wikibase-databridge-storybook sh -c rm -rf www/static/*; tar -C www/static/ -x # deploy locally built storybook (T237527)

Michael removed Michael as the assignee of this task.Nov 26 2019, 1:05 PM
In T237527#5693196, @Michael wrote:
In T237527#5693170, @Lucas_Werkmeister_WMDE wrote:

Actually, let’s put this in verification. Can someone update the storybook? (See T235763 for instructions.)

Can do.

Done.

This component can be verified there: https://tools-static.wmflabs.org/wikibase-databridge-storybook/?path=/story/iconmessagebox--notice

Maintenance_bot removed a project: Patch-For-Review.Nov 26 2019, 1:10 PM
Lydia_Pintscher added subscribers: Sarai-WMDE, Charlie_WMDE, Lydia_Pintscher.Nov 27 2019, 11:10 AM

@Charlie_WMDE and @Sarai-WMDE: leaving this for you to close.

Sarai-WMDE moved this task from Verification to To do on the Wikidata-Bridge-Sprint-10 board.Nov 27 2019, 11:30 AM

Hello, team! Charlie and I noticed that the size of the infoFilled icon is not correct in Storybook. Following Wikimedia's Style guide, the size of this icon should be 20x20px.

(Personally, let me anticipate that we'll be defining new standard icon sizes soon, 20px being the L size)

Thanks!

gerritbot added a comment.Nov 27 2019, 11:59 AM

Change 553328 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: adjustments of IconMessageBox

https://gerrit.wikimedia.org/r/553328

gerritbot added a project: Patch-For-Review.Nov 27 2019, 11:59 AM
• Matthias_Geisler_WMDE claimed this task.Nov 27 2019, 12:03 PM
• Matthias_Geisler_WMDE moved this task from To do to Peer Review on the Wikidata-Bridge-Sprint-10 board.
gerritbot added a comment.Nov 28 2019, 2:15 PM

Change 553328 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: adjustments of IconMessageBox

https://gerrit.wikimedia.org/r/553328

Michael moved this task from Peer Review to Verification on the Wikidata-Bridge-Sprint-10 board.Nov 28 2019, 2:37 PM

@Charlie_WMDE @Sarai-WMDE: We adjusted the global styles of the Storybook so that it should be by default closer to the OOUI Demo page. Could you verify this component again?

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.10; 2019-12-10); removed MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 28 2019, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 28 2019, 3:10 PM
Stashbot added a comment.Nov 28 2019, 4:47 PM

Mentioned in SAL (#wikimedia-cloud) [2019-11-28T16:47:41Z] <wm-bot> <migr> npm run build-storybook && tar -C storybook-static -c . | ssh toolforge "sudo -i -u tools.wikibase-databridge-storybook sh -c 'rm -rf www/static/*; tar -C www/static/ -x'" # deploy locally built storybook (T237527, 2nd revision with adjusted storybook config)

Charlie_WMDE closed this task as Resolved.Dec 2 2019, 12:42 PM
Charlie_WMDE moved this task from Doing to Done on the Wikidata-Bridge-Sprint-9 board.

looks good!

Lucas_Werkmeister_WMDE moved this task from Verification to Done on the Wikidata-Bridge-Sprint-10 board.Dec 2 2019, 4:48 PM
Lucas_Werkmeister_WMDE moved this task from Done to Doing on the Wikidata-Bridge-Sprint-9 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL