Page MenuHomePhabricator
Create Task
Maniphest T237556

Detect html2wt reqs issued to Parsoid/PHP with data-parsoid blobs generated by Parsoid/JS and issue a HTTP 421
Closed, ResolvedPublic
Actions

Description

If Parsoid/PHP gets a html2wt request with a data-parsoid blob generated by Parsoid/JS, we should reject it since we will severely corrupt the page if it went through given that Parsoid/PHP use byte offsets for data-parsoid and Parsoid/JS uses ucs2 offsets.

Fortunately, the fix for T222738: Add annotation about offset-type in the data-parsoid blob adds annotations to the data-parsoid blob which makes this detection simple.

HTTP 421 (Misdirected request) seems like the appropriate response in this case allowing RESTBase to retry with a request to Parsoid/JS instead.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Return a 421 Misdirected Request if offsetType in incorrectmediawiki/services/parsoidmaster+15 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

ssastry created this task.Nov 6 2019, 5:43 PM
ssastry triaged this task as High priority.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 6 2019, 5:43 PM
ssastry added a parent task: T229015: Tracking: Direct live production traffic at Parsoid/PHP.Nov 6 2019, 5:44 PM
ssastry renamed this task from Detect html2wt reqs issued to Parsoid/PHP with data-parsoid blobs generated by Parsoid/JS and issue a HTTP 400 to Detect html2wt reqs issued to Parsoid/PHP with data-parsoid blobs generated by Parsoid/JS and issue a HTTP 421.Nov 6 2019, 5:48 PM
ssastry updated the task description. (Show Details)
ssastry moved this task from Backlog to Deployment on the Parsoid-PHP board.Nov 6 2019, 5:53 PM
• mobrovac mentioned this in T237563: RESTBase should fall back to Parsoid/JS if it receives 421 from Parsoid/PHP.Nov 6 2019, 6:09 PM
• mobrovac added a parent task: T237563: RESTBase should fall back to Parsoid/JS if it receives 421 from Parsoid/PHP.
Arlolra claimed this task.Nov 7 2019, 12:11 AM
ssastry removed a parent task: T229015: Tracking: Direct live production traffic at Parsoid/PHP.Nov 7 2019, 9:38 PM
gerritbot added a comment.Nov 7 2019, 11:45 PM

Change 549667 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Return a 421 Misdirected Request if offsetType in incorrect

https://gerrit.wikimedia.org/r/549667

gerritbot added a project: Patch-For-Review.Nov 7 2019, 11:45 PM
gerritbot added a comment.Nov 8 2019, 1:44 PM

Change 549667 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Return a 421 Misdirected Request if offsetType in incorrect

https://gerrit.wikimedia.org/r/549667

• mobrovac closed this task as Resolved.Nov 8 2019, 1:58 PM
• mobrovac removed a project: Patch-For-Review.
Stashbot mentioned this in T215000: Fill gaps in PHP DOM's functionality.Nov 12 2019, 7:18 PM
Stashbot mentioned this in T235295: MathML tags are missing xmlns attribute.
Stashbot mentioned this in T235656: Ref fragments remain unexpanded in Image:Frameless, mw:ExpandedAttrs, mw:LanguageVariant nodes.
Stashbot mentioned this in T235217: Parsoid should use protocol-relative URLs for media.
Stashbot mentioned this in T236846: TemplateHandler.php: trim() expects parameter 1 to be string, boolean given.

Mentioned in SAL (#wikimedia-operations) [2019-11-12T19:18:53Z] <arlolra> Updated Parsoid to 6a0a708 (T215000, T235295, T235656, T235217, T235295, T236846, T237556, T235231)

Stashbot mentioned this in T235231: Parsoid/JS video tag has a "seek" parameter in the URL that Parsoid/PHP video tag output doesn't.Nov 12 2019, 7:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits