Page MenuHomePhabricator

Curator reads minor flag of a revision
Open, MediumPublic

Description

"As a Curator, I want to know if a revision is marked as minor, so I can decide whether it needs review for content."

Contributors can voluntarily mark revisions as minor; it has different meanings for different wiki projects.

The schema for T231338 Page History API didn't include the minor flag for revision objects, which makes user stories like T234941 and T235572 harder to use.

For this user story, we need to add the minor flag to the output of GET /revision/{id}/bare, as defined in T231345.

Details

Related Gerrit Patches:
mediawiki/tools/api-testing : masterREST: Test for revision minor flag
mediawiki/core : masterREST: Introduce 'minor' flag in revision response

Event Timeline

eprodromou triaged this task as Medium priority.Nov 6 2019, 9:04 PM

Change 549594 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] REST: Introduce 'minor' flag in revision response

https://gerrit.wikimedia.org/r/549594

The patch above adds minor flag to both /revision/{id}/bare and /page/{title}/history endpoints.

After it's merged:

  • Update integration tests
  • Update documentation

Change 549594 merged by jenkins-bot:
[mediawiki/core@master] REST: Introduce 'minor' flag in revision response

https://gerrit.wikimedia.org/r/549594

Change 549897 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/tools/api-testing@master] REST: Test for revision minor flag

https://gerrit.wikimedia.org/r/549897

Updated the docs with the minor property.

So, I appreciate the quick response time, which has been really helpful getting the page history endpoints done.

But now that they are in production, we need to consider versioning before making even minor changes to existing endpoints.

I opened ticket T237854 for talking about it.

Also, I'd like us to consider versioning in the documentation. @apaskulin if you could give some insight on that ticket, it would be helpful.

Change 549897 merged by jenkins-bot:
[mediawiki/tools/api-testing@master] REST: Test for revision minor flag

https://gerrit.wikimedia.org/r/549897