Page MenuHomePhabricator
Create Task
Maniphest T237600

Homepage: unable to distinguish between clicks and impressions on mobile
Closed, ResolvedPublic
Actions

Description

This task blocks the release of Newcomer Tasks 1.0 because it will affect the instrumentation for mobile.

Desired behavior

When a user visits the mobile homepage, they are supposed to end up with seven events: one for each module, with event.action = 'impression' and event.mode = 'mobile-summary'. Then when they tap a module preview, they are supposed to get an event with event.action = 'impression' and event.mode = 'mobile-overlay'.

Current behavior

Right now, when a user visits the mobile homepage, they get fourteen events: seven impression events with event.mode ='mobile-summary' and seven impression events with event.mode = 'mobile-overlay'. This makes it impossible to tell when a user actually taps a module preview from the homepage to open it up, because the extra 'mobile-overlay' impressions from visiting pollute the data.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/GrowthExperimentswmf/1.35.0-wmf.5+1 -1Instrumentation: Don't log mobile-overlay impression in summary view
mediawiki/extensions/GrowthExperimentsmaster+1 -1Instrumentation: Don't log mobile-overlay impression in summary view
Customize query in gerrit

Related Objects
Search...

Event Timeline

MMiller_WMF created this task.Nov 7 2019, 2:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2019, 2:07 AM
MMiller_WMF added parent tasks: T213990: [EPIC] Growth: Newcomer homepage, T230068: Newcomer tasks: instrumentation.Nov 7 2019, 2:07 AM
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.

@Tgr @Catrope @kostajh -- I just noticed and filed this about an issue in mobile events for the homepage. This is also relevant for newcomer tasks, because it affects our ability to tell when a user opens up the module.

MMiller_WMF updated the task description. (Show Details)Nov 7 2019, 2:14 AM
kostajh claimed this task.Nov 7 2019, 1:48 PM
kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
kostajh added a comment.Nov 7 2019, 1:59 PM

Looks like this was caused by 3a0738e

gerritbot added a comment.Nov 7 2019, 2:16 PM

Change 549468 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Instrumentation: Don't log mobile-overlay impression in summary view

https://gerrit.wikimedia.org/r/549468

gerritbot added a project: Patch-For-Review.Nov 7 2019, 2:16 PM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Current Sprint) board.Nov 7 2019, 2:20 PM
gerritbot added a comment.Nov 7 2019, 7:59 PM

Change 549468 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Instrumentation: Don't log mobile-overlay impression in summary view

https://gerrit.wikimedia.org/r/549468

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 7 2019, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 7 2019, 8:10 PM
Catrope added a comment.Nov 7 2019, 10:20 PM

If Kosta is right about which change introduced this (I haven't double-checked but he probably is), then this bug hit production on September 5th.

gerritbot added a comment.Nov 7 2019, 11:53 PM

Change 549669 had a related patch set uploaded (by Catrope; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.5] Instrumentation: Don't log mobile-overlay impression in summary view

https://gerrit.wikimedia.org/r/549669

gerritbot added a project: Patch-For-Review.Nov 7 2019, 11:53 PM
gerritbot added a comment.Nov 8 2019, 12:15 AM

Change 549669 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.5] Instrumentation: Don't log mobile-overlay impression in summary view

https://gerrit.wikimedia.org/r/549669

Stashbot added a comment.Nov 8 2019, 12:44 AM

Mentioned in SAL (#wikimedia-operations) [2019-11-08T00:44:58Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/GrowthExperiments/modules/homepage/ext.growthExperiments.Homepage.Logging.js: Fix homepage instrumentation (T237600) (duration: 00m 52s)

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.5; 2019-11-05); removed MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 8 2019, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 8 2019, 1:10 AM
JTannerWMF moved this task from Backlog to Doing on the NewcomerTasks 1.0 board.Nov 8 2019, 6:19 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Nov 12 2019, 2:50 PM
Etonkovidova closed this task as Resolved.Dec 3 2019, 12:24 AM

Checked in betalabs - mobile-overlay is recorded only when a user taps the module.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL