Page MenuHomePhabricator

Homepage: unable to distinguish between clicks and impressions on mobile
Open, Needs TriagePublic

Description

This task blocks the release of Newcomer Tasks 1.0 because it will affect the instrumentation for mobile.

Desired behavior

When a user visits the mobile homepage, they are supposed to end up with seven events: one for each module, with event.action = 'impression' and event.mode = 'mobile-summary'. Then when they tap a module preview, they are supposed to get an event with event.action = 'impression' and event.mode = 'mobile-overlay'.

Current behavior

Right now, when a user visits the mobile homepage, they get fourteen events: seven impression events with event.mode ='mobile-summary' and seven impression events with event.mode = 'mobile-overlay'. This makes it impossible to tell when a user actually taps a module preview from the homepage to open it up, because the extra 'mobile-overlay' impressions from visiting pollute the data.

Details

Related Gerrit Patches:
mediawiki/extensions/GrowthExperiments : wmf/1.35.0-wmf.5Instrumentation: Don't log mobile-overlay impression in summary view
mediawiki/extensions/GrowthExperiments : masterInstrumentation: Don't log mobile-overlay impression in summary view

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Nov 7, 2:07 AM

@Tgr @Catrope @kostajh -- I just noticed and filed this about an issue in mobile events for the homepage. This is also relevant for newcomer tasks, because it affects our ability to tell when a user opens up the module.

MMiller_WMF updated the task description. (Show Details)Thu, Nov 7, 2:14 AM

Looks like this was caused by 3a0738e

Change 549468 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Instrumentation: Don't log mobile-overlay impression in summary view

https://gerrit.wikimedia.org/r/549468

Change 549468 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Instrumentation: Don't log mobile-overlay impression in summary view

https://gerrit.wikimedia.org/r/549468

If Kosta is right about which change introduced this (I haven't double-checked but he probably is), then this bug hit production on September 5th.

Change 549669 had a related patch set uploaded (by Catrope; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.5] Instrumentation: Don't log mobile-overlay impression in summary view

https://gerrit.wikimedia.org/r/549669

Change 549669 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.5] Instrumentation: Don't log mobile-overlay impression in summary view

https://gerrit.wikimedia.org/r/549669

Mentioned in SAL (#wikimedia-operations) [2019-11-08T00:44:58Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/GrowthExperiments/modules/homepage/ext.growthExperiments.Homepage.Logging.js: Fix homepage instrumentation (T237600) (duration: 00m 52s)

JTannerWMF moved this task from Backlog to Doing on the NewcomerTasks 1.0 board.Fri, Nov 8, 6:19 PM