Fatal when trying to undo Commons edits: InvalidArgumentException "Unsaved old revision passed" from RevisionStore
Closed, DuplicatePublicPRODUCTION ERROR
Actions

Assigned To

None

Authored By

	• mmodell
	Nov 7 2019, 7:26 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

• mmodell

• Pchelolo

Description

Error

MediaWiki version: 1.35.0-wmf.5
URL: https://commons.wikimedia.org/w/index.php?title=File:Creditcardwcontactless.png&action=mcrundo&undo=373965317&undoafter=368054279

message

[{exception_id}] {exception_url}   InvalidArgumentException from line 3272 of /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision/RevisionStore.php: Unsaved old revision passed

Impact

production logspam

Notes

Details

Request ID: XcRgGApAAD0AACrgKUAAAABF
Request URL: https://commons.wikimedia.org/w/index.php?title=File:Creditcardwcontactless.png&action=mcrundo&undo=373965317&undoafter=368054279

Stack Trace

exception.trace

#0 /includes/Revision/RevisionStore.php(3482): MediaWiki\Revision\RevisionStore->assertRevisionParameter(string, integer, MediaWiki\Revision\MutableRevisionRecord)
#1 /includes/diff/DifferenceEngine.php(1525): MediaWiki\Revision\RevisionStore->countRevisionsBetween(integer, MediaWiki\Revision\MutableRevisionRecord, MediaWiki\Revision\RevisionStoreCacheRecord, integer)
#2 /includes/diff/DifferenceEngine.php(1052): DifferenceEngine->getMultiNotice()
#3 /includes/actions/McrUndoAction.php(242): DifferenceEngine->getDiff(string, string)
#4 /includes/actions/McrUndoAction.php(374): McrUndoAction->generateDiffOrPreview()
#5 /includes/htmlform/fields/HTMLInfoField.php(25): McrUndoAction->{closure}(array)
#6 /includes/htmlform/HTMLForm.php(1699): HTMLInfoField->getDefault()
#7 /includes/htmlform/HTMLForm.php(1299): HTMLForm->displaySection(array, string)
#8 /includes/htmlform/OOUIHTMLForm.php(254): HTMLForm->getBody()
#9 /includes/htmlform/HTMLForm.php(1076): OOUIHTMLForm->getBody()
#10 /includes/htmlform/HTMLForm.php(1055): HTMLForm->getHTML(boolean)
#11 /includes/htmlform/HTMLForm.php(606): HTMLForm->displayForm(boolean)
#12 /includes/actions/FormAction.php(143): HTMLForm->show()
#13 /includes/actions/McrUndoAction.php(90): FormAction->show()
#14 /includes/MediaWiki.php(514): McrUndoAction->show()
#15 /includes/MediaWiki.php(304): MediaWiki->performAction(ImagePage, Title)
#16 /includes/MediaWiki.php(967): MediaWiki->performRequest()
#17 /includes/MediaWiki.php(530): MediaWiki->main()
#18 /index.php(46): MediaWiki->run()
#19 /srv/mediawiki/w/index.php(3): require(string)
#20 {main}

Related Objects

Mentioned In: T236320: Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed"
Mentioned Here: T236320: Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed"

Event Timeline

• mmodell created this task.Nov 7 2019, 7:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2019, 7:26 PM

• mmodell renamed this task from Unsaved old revision passed to RevisionStore: Unsaved old revision passed.Nov 7 2019, 7:26 PM

• mmodell added a project: MediaWiki-Core-Revision-backend.Nov 7 2019, 7:30 PM

• mmodell updated the task description. (Show Details)

• mmodell changed Request URL from /w/index.php?title=File:Creditcardwcontactless.png&action=mcrundo&undo=373965317&undoafter=368054279 to https://commons.wikimedia.org/w/index.php?title=File:Creditcardwcontactless.png&action=mcrundo&undo=373965317&undoafter=368054279.

• mmodell updated the task description. (Show Details)Nov 7 2019, 7:34 PM

Krinkle renamed this task from RevisionStore: Unsaved old revision passed to InvalidArgumentException from RevisionStore: "Unsaved old revision passed".Nov 7 2019, 8:43 PM

Krinkle renamed this task from InvalidArgumentException from RevisionStore: "Unsaved old revision passed" to Fatal when trying to undo Commons edits: InvalidArgumentException "Unsaved old revision passed" from RevisionStore.

Krinkle triaged this task as High priority.

Krinkle updated the task description. (Show Details)

Krinkle added projects: Platform Engineering, MediaWiki-Page-editing.

Krinkle moved this task from Untriaged to Nov2019/1.35.wmf.5+ on the Wikimedia-production-error board.

Seems to be a duplicate of T236320

Krinkle closed this task as a duplicate of T236320: Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed".Nov 7 2019, 9:07 PM

Krinkle mentioned this in T236320: Internal error while undoing file captions: "InvalidArgumentException: Unsaved revision passed".