Page MenuHomePhabricator

[mobile] Newcomer tasks - <vector-view-edit> is displayed in intro overlay
Open, Needs TriagePublic

Description

Instead of "Edit", mobile displays <vector-view-edit> in the intro overlay:

Compare with the desktop:

Details

Related Gerrit Patches:
mediawiki/extensions/GrowthExperiments : masterStartEditingDialog: Make sure vector-view-edit message is exported

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Nov 8, 3:29 AM
Etonkovidova renamed this task from [mobile] Newcomer tasks - <vector-view-edit> is displayed in intor overlay to [mobile] Newcomer tasks - <vector-view-edit> is displayed in intro overlay.Fri, Nov 8, 3:29 AM
Etonkovidova updated the task description. (Show Details)Fri, Nov 8, 3:33 AM

@Etonkovidova -- I don't understand this bug. You wrote that the issue happens in mobile, but the screenshots you're showing are from desktop.

Change 551628 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Make sure vector-view-edit message is exported

https://gerrit.wikimedia.org/r/551628

The attached patch fixes this by exporting the vector-view-edit message, but it's more of a band-aid than a real solution. A proper solution (which we should do after v1.0) could involve injecting the text of the edit link as a parameter (if possible; there isn't an edit tab on the homepage, so we might not be able to do this), and we'd probably also want a different message for mobile (where the edit button doesn't have a text label, but an icon instead).

Change 551628 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Make sure vector-view-edit message is exported

https://gerrit.wikimedia.org/r/551628

@Catrope -- could you please file the task for the proper solution?

For Design Review - the issue is fixed (checked in betalabs).

RHo added a subscriber: RHo.

Seems to be fixed in Prod on CS and KO:

There are a few mobile issues, but will save comments for T236854.