Instead of "Edit", mobile displays <vector-view-edit> in the intro overlay:
 |  |
Compare with the desktop:
 |  |
Description
Description
Details
Details
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/GrowthExperiments | master | +2 -1 | StartEditingDialog: Make sure vector-view-edit message is exported |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | MMiller_WMF | T227728 [EPIC] Growth: Newcomer tasks 1.0 | |||
| Resolved | Catrope | T232419 Newcomer tasks: suggested edits initiation and overlays | |||
| Resolved | Catrope | T235723 Newcomer tasks: intro and difficulty overlays | |||
| Resolved | MMiller_WMF | T237710 [mobile] Newcomer tasks - <vector-view-edit> is displayed in intro overlay |
Event Timeline
Comment Actions
@Etonkovidova -- I don't understand this bug. You wrote that the issue happens in mobile, but the screenshots you're showing are from desktop.
Comment Actions
Change 551628 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Make sure vector-view-edit message is exported
Comment Actions
The attached patch fixes this by exporting the vector-view-edit message, but it's more of a band-aid than a real solution. A proper solution (which we should do after v1.0) could involve injecting the text of the edit link as a parameter (if possible; there isn't an edit tab on the homepage, so we might not be able to do this), and we'd probably also want a different message for mobile (where the edit button doesn't have a text label, but an icon instead).
Comment Actions
Change 551628 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] StartEditingDialog: Make sure vector-view-edit message is exported
Comment Actions
Seems to be fixed in Prod on CS and KO:
 |  |
There are a few mobile issues, but will save comments for T236854.