Page MenuHomePhabricator

Reduce length of extension name and description for Chrome
Open, Needs TriagePublic

Description

Chrome has maximum length requirements for the name and description messages in manifest.json. We currently have a few that are too long.

The build process should highlight the long ones, and truncate them for the build.

Event Timeline

Samwilson created this task.Nov 8 2019, 6:59 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptNov 8 2019, 6:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Samwilson added a comment.EditedNov 21 2019, 4:02 AM

That PR has been merged. A tiny follow-up to fix an incorrect variable name is ready for review: https://github.com/wikimedia/WhoWroteThat/pull/95

The next thing to figure out here is that some existing messages are already too long:

-----------------------------------------------------------------------------------------------------------------------------------|← 132 chars
>> The fr 'whowrotethat-ext-desc' message must be 132 characters or less. Provided:
Explorer la paternité et les informations de révision visuellement et directement dans les articles de Wikipédia. Fourni par WikiWho.

>> The mk 'whowrotethat-ext-desc-beta' message must be 132 characters or less. Provided:
Ова е БЕТА-верзија, предвидена само за испробување и може да содржи грешки. Ако наидете на некоја, пријавете ја на нашата табла на Фабрикатор.
>> The pt 'whowrotethat-ext-desc-beta' message must be 132 characters or less. Provided:
Esta é a versão BETA, destinada apenas a testes e possivelmente contendo erros. Se encontrar quaisquer problemas, por favor, reporte-o no nosso quadro do Phabricator.
>> The roa-tara 'whowrotethat-ext-desc-beta' message must be 132 characters or less. Provided:
Queste jè 'na versione BETA, fatte sulamende pu test e pò essere ca tène bug. Ce iacchie probbleme, pe piacere segnalele a 'u nostre conziglie Phabricator.
-----------------------------------------------------------------------------------------------------------------------------------|

These are being truncated for display on the Chrome store, so we could just leave it to the translators to fix them over time. Or do we want to actively reach and and ask that they be changed? I think probably the former, because anyway at some future point someone might add an overly-long message, and they'll have to be updated manually then too.

Samwilson added a subscriber: ifried.

The messages are now truncated to the required lengths, and this is ready for QA.

@ifried The question remains about what to do about the overly-long existing messages (see above).

@Samwilson Small nitpick. We seem to be warning about descriptions that are 132 characters or greater, and truncating up to the 131st character. Should it not be strictly greater than 132 characters?

Similarly for the name.