Page MenuHomePhabricator

Replace StringMatcher used in TAGS configuration with fnmatch
Open, Needs TriagePublic

Description

The TAGS code uses the StringMatcher class. It's functionality is similar to fnmatch.

Check if that is the case, and simplify the StringMatcher code to use fnmatch as well.

Further notes from Niklas,

I believe PHP's fnmatch is pretty well optimized. See for example https://research.swtch.com/glob, which does not talk about PHP, but suggests that linear time algorithm is what we want. I looked at the PHP code briefly and seemed okay.

Event Timeline

abi_ created this task.Sat, Nov 9, 10:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Nov 9, 10:03 AM