Page MenuHomePhabricator

Attempting to view diffs of a deleted version fails with internal error InvalidArgumentException
Closed, DuplicatePublicBUG REPORT

Description

Attempting to view diffs of a deleted version leads to an internal error

Steps to reproduce:

  1. Have a page with some revisions
  2. Have the access to see deleted revisions
  3. Have the page in (1) deleted
  4. Attempt to "view diff" across deleted revisions
  5. STOP: ERROR

Able to produce on enwiki and testwiki.

From testwiki:
https://test.wikipedia.org/w/index.php?title=Special:Undelete&target=User%3AXaosflux%2Fsandbox20191109&timestamp=20191109191230&diff=prev

[XccPrgpAAEEAAG1CiLIAAABE] /w/index.php?title=Special:Undelete&target=User%3AXaosflux%2Fsandbox20191109&timestamp=20191109191230&diff=prev InvalidArgumentException from line 3275 of /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision/RevisionStore.php: Revision 408371 doesn't belong to page 0

Backtrace:

#0 /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision/RevisionStore.php(3482): MediaWiki\Revision\RevisionStore->assertRevisionParameter(string, integer, MediaWiki\Revision\RevisionArchiveRecord)
#1 /srv/mediawiki/php-1.35.0-wmf.5/includes/diff/DifferenceEngine.php(1552): MediaWiki\Revision\RevisionStore->countRevisionsBetween(integer, MediaWiki\Revision\RevisionArchiveRecord, MediaWiki\Revision\RevisionArchiveRecord, integer)
#2 /srv/mediawiki/php-1.35.0-wmf.5/includes/diff/DifferenceEngine.php(1052): DifferenceEngine->getMultiNotice()
#3 /srv/mediawiki/php-1.35.0-wmf.5/includes/specials/SpecialUndelete.php(583): DifferenceEngine->getDiff(string, string)
#4 /srv/mediawiki/php-1.35.0-wmf.5/includes/specials/SpecialUndelete.php(429): SpecialUndelete->showDiff(Revision, Revision)
#5 /srv/mediawiki/php-1.35.0-wmf.5/includes/specials/SpecialUndelete.php(204): SpecialUndelete->showRevision(string)
#6 /srv/mediawiki/php-1.35.0-wmf.5/includes/specialpage/SpecialPage.php(575): SpecialUndelete->execute(NULL)
#7 /srv/mediawiki/php-1.35.0-wmf.5/includes/specialpage/SpecialPageFactory.php(607): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#9 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(967): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(530): MediaWiki->main()
#11 /srv/mediawiki/php-1.35.0-wmf.5/index.php(46): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}

Event Timeline

Xaosflux created this task.Nov 9 2019, 7:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 9 2019, 7:16 PM
Xaosflux renamed this task from Attempting to view diffs of a deleted version leads to an internal error to Attempting to view diffs of a deleted version fails with internal error InvalidArgumentException.Nov 9 2019, 7:16 PM
Xaosflux changed the subtype of this task from "Task" to "Bug Report".

Appears to have been caused by T235896