Live preview not working with skins not shown in preferences
Closed, ResolvedPublic
Actions

Description

Steps to Reproduce:

Enable “Show previews without reloading the page” in Preferences / Editing.
Open a page for editing with useskin=cologneblue, e.g. https://en.wikipedia.org/w/index.php?title=User:Tacsipacsi&action=edit&useskin=cologneblue
Click Show preview.

Actual Results:
An error message appears with API error unknown_useskin.

Expected Results:
The preview appears.

(Note that although this bug is most easily reproducible using the live preview feature and the Cologne Blue skin, I don’t think any of them are buggy—live preview is simply a front-end to the API, and Cologne Blue is a skin hidden from preferences.)

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+33 -19	ApiParse: Support hidden skins

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T223824 Hide Cologne Blue skin in preferences
		Resolved		Ammarpad	T237856 Live preview not working with skins not shown in preferences

Event Timeline

Tacsipacsi created this task.Nov 10 2019, 2:51 PM

Restricted Application added a project: Platform Engineering. · View Herald TranscriptNov 10 2019, 2:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Tacsipacsi added a parent task: T223824: Hide Cologne Blue skin in preferences .Nov 10 2019, 2:52 PM

Reedy added projects: CologneBlue, MediaWiki-Interface.Nov 11 2019, 1:36 AM

• mobrovac edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Nov 12 2019, 10:39 AM

The API is declaring valid values for the parameter using Skin::getAllowedSkins(), which omits skins in $wgSkipSkins. That could be changed to use Skin::getSkinNames() which doesn't check $wgSkipSkins. A side effect would be that it would also list the internal skins "fallback" and "apioutput"; that's probably ok.

daniel triaged this task as Low priority.Nov 12 2019, 10:51 PM

WDoranWMF moved this task from Inbox to Backlog on the Platform Team Workboards (Clinic Duty Team) board.Mar 12 2020, 1:35 PM

• AMooney moved this task from Backlog to Teleport on the Platform Team Workboards (Clinic Duty Team) board.Mar 24 2020, 1:47 PM

WDoranWMF edited projects, added Platform Engineering (Icebox); removed Platform Team Workboards (Clinic Duty Team).Mar 24 2020, 9:48 PM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:02 PM

Jdlrobson moved this task from Backlog to Tracking on the CologneBlue board.Jan 22 2021, 1:35 AM

Jdlrobson edited projects, added CologneBlue (Tracking); removed CologneBlue.

Tacsipacsi merged a task: T287824: Edit Preview: Unrecognized value for parameter "useskin": modern..Aug 1 2021, 5:39 PM

Tacsipacsi added projects: MediaWiki-Page-editing, Modern, Regression.

Tacsipacsi moved this task from Backlog to Live preview on the MediaWiki-Page-editing board.

Tacsipacsi added a subscriber: Tikmok.

Intention of both T287616 and T223824 is to let existing users to continue using these skins with no change in behavior, so the API should support these skins since they are not really disabled. We can either go with T237856#5656455 or just add the skipped skins to the allowed values (which will avoid listing the internal skins; albeit they're already supported with ?useskin parameter anyway).

Ammarpad renamed this task from Live preview not working with Cologne Blue to Live preview not working with skins not shown in preference.Aug 8 2021, 1:28 PM

Change 710678 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] ApiParse: Support hidden skins

https://gerrit.wikimedia.org/r/710678

gerritbot added a project: Patch-For-Review.Aug 8 2021, 3:01 PM

Tacsipacsi renamed this task from Live preview not working with skins not shown in preference to Live preview not working with skins not shown in preferences.Aug 8 2021, 7:10 PM

Izno mentioned this in T287616: Hide Modern in skin preferences.Aug 11 2021, 11:17 PM

Change 710678 merged by jenkins-bot:

[mediawiki/core@master] ApiParse: Support hidden skins

https://gerrit.wikimedia.org/r/710678

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 20 2021, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 20 2021, 4:11 PM

Ammarpad closed this task as Resolved.Oct 11 2021, 7:13 PM

Ammarpad claimed this task.