Page MenuHomePhabricator

Remove and empty useless user groups
Closed, ResolvedPublic

Description

User groups that should be emptied and removed after gutted OSM is deployed:

  • shell
  • cloudadmin
  • flood

Related Objects

StatusSubtypeAssignedTask
ResolvedClement_Goubert
OpenClement_Goubert
OpenNone
OpenNone
OpenNone
Resolved taavi
ResolvedAndrew
ResolvedAndrew
ResolvedAndrew
ResolvedAndrew
ResolvedMarcoAurelio
ResolvedAndrew
Resolved taavi
DeclinedNone
DuplicateNone
OpenNone
ResolvedSLyngshede-WMF
ResolvedNone
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedMarostegui
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedNone
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
OpenNone
OpenNone
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
OpenSLyngshede-WMF
ResolvedSLyngshede-WMF
ResolvedBUG REPORTSLyngshede-WMF
InvalidNone
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
OpenNone
OpenNone
ResolvedSLyngshede-WMF
ResolvedSLyngshede-WMF
OpenSLyngshede-WMF
OpenSLyngshede-WMF
ResolvedSLyngshede-WMF
OpenSLyngshede-WMF
Resolved taavi
Resolved taavi
ResolvedFeatureSLyngshede-WMF
ResolvedBUG REPORTSLyngshede-WMF
Resolvedbd808
Resolvedyuvipanda
Resolvedbd808
Resolvedbd808
Resolvedbd808
OpenSLyngshede-WMF
ResolvedNone
OpenNone
OpenFeatureNone
StalledFeatureNone
OpenFeatureSLyngshede-WMF
OpenSLyngshede-WMF
OpenSLyngshede-WMF
OpenSLyngshede-WMF
ResolvedABran-WMF
Resolved taavi
OpenNone
In ProgressSLyngshede-WMF
DuplicateNone
OpenNone
OpenNone
ResolvedMarostegui
ResolvedAndrew
ResolvedMarostegui
ResolvedAndrew
DeclinedAndrew
ResolvedAndrew
ResolvedAndrew
ResolvedLadsgroup
DuplicateNone
Resolved Bstorm
Resolved taavi
ResolvedJdforrester-WMF
DeclinedNone

Event Timeline

I don't think we should remove 'flood'. It allows (content)admins to avoid flooding recent changes when doing uncontroversial mass changes. In a wiki with so little activity like Wikitech, maintaining Recent Changes readable for others is a priority IMHO. No comments re. cloudamin or shell. Thanks.

Change 575390 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] [wikitech] Drop the 'cloudadmin' user group, no longer used and empty

https://gerrit.wikimedia.org/r/575390

Change 575391 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] [wikitech] Drop the 'flood' user group, no longer used and empty

https://gerrit.wikimedia.org/r/575391

Change 575391 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] [wikitech] Drop the 'flood' user group, no longer used and empty

https://gerrit.wikimedia.org/r/575391

Flood isn't meant to have users in it most of the time. It is temporarily added for mass actions to avoid flooding RecentChanges. It looks like @MarcoAurelio has been the only person to use it, most recently in 2017.

Change 575391 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] [wikitech] Drop the 'flood' user group, no longer used and empty

https://gerrit.wikimedia.org/r/575391

Flood isn't meant to have users in it most of the time. It is temporarily added for mass actions to avoid flooding RecentChanges. It looks like @MarcoAurelio has been the only person to use it, most recently in 2017.

That's right. Flood is a temporary self-added group to avoid flooding recent changes. It is not meant to be used permanently (that's what 'bot' would be for).

Anyone with +bot can just mark their edit as non-bot as they're making it (or via the API). If this was a key need that the group was a valuable group that has consensus to use, I'd expect we'd define it as a standard on more than a couple of dozen wikis.

I don't have any objections to removing it. I just wanted to point out that it should usually be empty.

Anyone with +bot can just mark their edit as non-bot as they're making it

How do you do this using the web UI?

Oh, did the checkbox not get added to the UI? Meh. Why don't we fix that instead?

I don't see one when I use the web UI to edit on my bot account. All edits are bot flagged.

For non-edit actions, there isn't a way to toggle it using the API or web UI. All are bot flagged.

Personally, I wouldn't block removing the group on fixing it since the group doesn't get much use.

I don't see one when I use the web UI to edit on my bot account. All edits are bot flagged.

For non-edit actions, there isn't a way to toggle it using the API or web UI. All are bot flagged.

Initial version at https://gerrit.wikimedia.org/r/575628 but it doesn't work quite yet.

Personally, I wouldn't block removing the group on fixing it since the group doesn't get much use.

Understood.

Couldn't you just temporally add yourself to the bot usergroup?

Couldn't you just temporally add yourself to the bot usergroup?

Content admins/standard admins can't do that.

Honestly, the content admin group is pointless and I suggest merging it with admin, like T246405 (but then that task got declined, so...)

Change 575390 merged by jenkins-bot:

[operations/mediawiki-config@master] [wikitech] Drop the 'cloudadmin' user group, no longer used and empty

https://gerrit.wikimedia.org/r/575390

Mentioned in SAL (#wikimedia-operations) [2022-01-19T17:50:51Z] <taavi@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:575390|[wikitech] Drop the cloudadmin user group, no longer used and empty (T237890)]] (duration: 00m 50s)

Change 755452 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/WikimediaMessages@master] wikitech: Drop names for removed groups

https://gerrit.wikimedia.org/r/755452

Change 755452 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] wikitech: Drop names for removed groups

https://gerrit.wikimedia.org/r/755452

taavi claimed this task.