Page MenuHomePhabricator

Remove and empty useless user groups
Open, Needs TriagePublic

Description

User groups that should be emptied and removed after gutted OSM is deployed:

  • shell
  • cloudadmin
  • flood

Details

Related Gerrit Patches:

Event Timeline

Reedy created this task.Nov 10 2019, 11:53 PM
bd808 moved this task from Backlog to Config on the wikitech.wikimedia.org board.Nov 11 2019, 12:05 AM

I don't think we should remove 'flood'. It allows (content)admins to avoid flooding recent changes when doing uncontroversial mass changes. In a wiki with so little activity like Wikitech, maintaining Recent Changes readable for others is a priority IMHO. No comments re. cloudamin or shell. Thanks.

Meno25 added a subscriber: Meno25.Nov 19 2019, 6:34 AM

What about contentadmin?

Change 575390 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] [wikitech] Drop the 'cloudadmin' user group, no longer used and empty

https://gerrit.wikimedia.org/r/575390

Change 575391 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] [wikitech] Drop the 'flood' user group, no longer used and empty

https://gerrit.wikimedia.org/r/575391

JJMC89 added a subscriber: JJMC89.Fri, Feb 28, 2:52 AM

Change 575391 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] [wikitech] Drop the 'flood' user group, no longer used and empty
https://gerrit.wikimedia.org/r/575391

Flood isn't meant to have users in it most of the time. It is temporarily added for mass actions to avoid flooding RecentChanges. It looks like @MarcoAurelio has been the only person to use it, most recently in 2017.

Change 575391 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] [wikitech] Drop the 'flood' user group, no longer used and empty
https://gerrit.wikimedia.org/r/575391

Flood isn't meant to have users in it most of the time. It is temporarily added for mass actions to avoid flooding RecentChanges. It looks like @MarcoAurelio has been the only person to use it, most recently in 2017.

That's right. Flood is a temporary self-added group to avoid flooding recent changes. It is not meant to be used permanently (that's what 'bot' would be for).

Anyone with +bot can just mark their edit as non-bot as they're making it (or via the API). If this was a key need that the group was a valuable group that has consensus to use, I'd expect we'd define it as a standard on more than a couple of dozen wikis.

I don't have any objections to removing it. I just wanted to point out that it should usually be empty.

Anyone with +bot can just mark their edit as non-bot as they're making it

How do you do this using the web UI?

Oh, did the checkbox not get added to the UI? Meh. Why don't we fix that instead?

I don't see one when I use the web UI to edit on my bot account. All edits are bot flagged.

For non-edit actions, there isn't a way to toggle it using the API or web UI. All are bot flagged.

Personally, I wouldn't block removing the group on fixing it since the group doesn't get much use.

I don't see one when I use the web UI to edit on my bot account. All edits are bot flagged.
For non-edit actions, there isn't a way to toggle it using the API or web UI. All are bot flagged.

Initial version at https://gerrit.wikimedia.org/r/575628 but it doesn't work quite yet.

Personally, I wouldn't block removing the group on fixing it since the group doesn't get much use.

Understood.

Couldn't you just temporally add yourself to the bot usergroup?