Page MenuHomePhabricator

Wikibase: Change JS-esque entries to Lua
Closed, ResolvedPublic

Description

The function calls in Lua is set up somewhat different from Javascript. The style in Javascript comes from the fact that JS does implicit hoisting of function calls. That don't happen in Lua.

Also, Lua handles table entry syntax quite well, so its not necessary to avoid it in a function name.

And (in addition) it is easier for the eye to scan for "function" along the left edge.

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterWikibase: Change function declarations to Lua-style

Event Timeline

jeblad created this task.Nov 11 2019, 5:04 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptNov 11 2019, 5:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 550060 had a related patch set uploaded (by John Erling Blad; owner: John Erling Blad):
[mediawiki/extensions/Wikibase@master] Wikibase: Change function declarations to Lua-style

https://gerrit.wikimedia.org/r/550060

Change 550060 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Wikibase: Change function declarations to Lua-style

https://gerrit.wikimedia.org/r/550060

hoo closed this task as Resolved.Nov 13 2019, 4:09 PM
hoo assigned this task to jeblad.