Migrate FUDForm to the new validator framework
Closed, ResolvedPublic
Actions

Description

Migrate the existing checker / suggester code to instead use the new validator framework. We need to add,

Validator for variable - /\$[1-9]/ that is insertable and enforced.
Validator for variable - /{VAR: [^}]+}/ that is insertable and enforced.
Plural - {PLURAL: u->posted_msg_count|$1 Message|$1 Messages} - Currently checking to make sure translators are not using {{PLURAL, instead of {PLURAL. This will need a custom validator.

We'll need to update the YAML configuration file located here - https://phabricator.wikimedia.org/diffusion/GTWN/browse/master/groups/

Documentation: https://www.mediawiki.org/wiki/Help:Extension:Translate/Validators
Example patch: https://gerrit.wikimedia.org/r/c/translatewiki/+/549930

Details

	Project	Branch	Lines +/-	Subject
	translatewiki	master	+5 -0	Add insertable suggester for HTML entities for FUDForum
	translatewiki	master	+35 -82	Update FUDForum to use the new validator framework

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T195760 Language Annual Plan 2018-2019
Open	None	T204818 Language tools maintenance intervention: Improve the quality of translations for Translate extension
Resolved	abi_	T204568 Extend message checker framework to support errors that prevent saving
Resolved	abi_	T224025 Migrate existing projects to use the new Validator framework
Resolved	abi_	T237909 Migrate FUDForm to the new validator framework

Event Timeline

abi_ created this task.Nov 11 2019, 7:54 AM

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptNov 11 2019, 7:54 AM

abi_ added a parent task: T224025: Migrate existing projects to use the new Validator framework.Nov 11 2019, 7:54 AM

Related Googe Code-in task: https://codein.withgoogle.com/dashboard/tasks/5680370624757760

Ping: @Urbanecm

Urbanecm moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.Nov 26 2019, 4:43 PM

Nikerabbit moved this task from Backlog to Configuration changes on the translatewiki.net board.Dec 22 2019, 12:54 PM

abi_ claimed this task.Feb 4 2020, 9:23 AM

abi_ triaged this task as Medium priority.

abi_ added a project: Language-Team (Language-2020-January-March).

Change 569844 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Update FUDForum to use the new validator framework

https://gerrit.wikimedia.org/r/569844

gerritbot added a project: Patch-For-Review.Feb 4 2020, 9:28 AM

abi_ moved this task from Backlog to In Review on the Language-Team (Language-2020-January-March) board.Feb 4 2020, 9:31 AM

Change 569844 merged by jenkins-bot:
[translatewiki@master] Update FUDForum to use the new validator framework

https://gerrit.wikimedia.org/r/569844

jenkins-bot mentioned this in rGTWN83b0a27d85e3: Update FUDForum to use the new validator framework.Feb 10 2020, 9:06 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 10 2020, 9:10 AM

Change 571258 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Add insertable suggester for HTML entities for FUDForum

https://gerrit.wikimedia.org/r/571258

gerritbot added a project: Patch-For-Review.Feb 10 2020, 9:54 AM

Change 571258 merged by jenkins-bot:
[translatewiki@master] Add insertable suggester for HTML entities for FUDForum

https://gerrit.wikimedia.org/r/571258

abi_ mentioned this in rGTWN49cb43577c12: Add insertable suggester for HTML entities for FUDForum.Feb 10 2020, 11:36 AM