Page MenuHomePhabricator

Migrate Huggle to the new validator framework
Closed, ResolvedPublic

Description

Migrate the existing checker / suggester code to instead use the new validator framework. We need to add,

  1. A validator to replicate - wikiParameterCheck. We can add a custom validator and use that instead of defining a regex everytime. Insertable with a warning.
  2. A validator to replicate the old - NumericalParameterInsertablesSuggester - Regex: /\$\d+/. Insertable with a warning.

We'll need to update the YAML configuration file located here - https://phabricator.wikimedia.org/diffusion/GTWN/browse/master/groups/

Documentation: https://www.mediawiki.org/wiki/Help:Extension:Translate/Validators
Example patch: https://gerrit.wikimedia.org/r/c/translatewiki/+/549930

Event Timeline

...with a warning.

Does this mean that I need to enable an enforce property?

...with a warning.

Does this mean that I need to enable an enforce property?

Warning not error, so still enforce: false. Error would be enforce: true

...with a warning.

Does this mean that I need to enable an enforce property?

Warning not error, so still enforce: false. Error would be enforce: true

Got it.

Change 557034 had a related patch set uploaded (by Crutishnyk; owner: Crutishnyk):
[translatewiki@master] Update Huggle to use the new validator framework

https://gerrit.wikimedia.org/r/557034

Change 557034 merged by jenkins-bot:
[translatewiki@master] Update Huggle to use the new validator framework

https://gerrit.wikimedia.org/r/557034

This has been done and deployed on translatewiki.net