Migrate Huggle to the new validator framework
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	abi_
	Nov 11 2019, 8:03 AM

Description

Migrate the existing checker / suggester code to instead use the new validator framework. We need to add,

A validator to replicate - wikiParameterCheck. We can add a custom validator and use that instead of defining a regex everytime. Insertable with a warning.
A validator to replicate the old - NumericalParameterInsertablesSuggester - Regex: /\$\d+/. Insertable with a warning.

We'll need to update the YAML configuration file located here - https://phabricator.wikimedia.org/diffusion/GTWN/browse/master/groups/

Documentation: https://www.mediawiki.org/wiki/Help:Extension:Translate/Validators
Example patch: https://gerrit.wikimedia.org/r/c/translatewiki/+/549930

Details

	Project	Branch	Lines +/-	Subject
	translatewiki	master	+4 -7	Update Huggle to use the new validator framework

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T195760 Language Annual Plan 2018-2019
Resolved	Nikerabbit	T204818 Language tools maintenance intervention: Improve the quality of translations for Translate extension
Resolved	abi_	T204568 Extend message checker framework to support errors that prevent saving
Resolved	abi_	T224025 Migrate existing projects to use the new Validator framework
Resolved	Crutishnyk	T237910 Migrate Huggle to the new validator framework

Event Timeline

abi_ created this task.Nov 11 2019, 8:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 11 2019, 8:03 AM

abi_ added a parent task: T224025: Migrate existing projects to use the new Validator framework.Nov 11 2019, 8:10 AM

Related Google Code-in task: https://codein.withgoogle.com/dashboard/tasks/5105925409472512/

Ping: @Urbanecm

Published

Urbanecm moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.Nov 11 2019, 10:13 PM

...with a warning.

Does this mean that I need to enable an enforce property?

In T237910#5739283, @Crutishnyk wrote:

...with a warning.

Does this mean that I need to enable an enforce property?

Warning not error, so still enforce: false. Error would be enforce: true

In T237910#5739336, @abi_ wrote:

In T237910#5739283, @Crutishnyk wrote:

...with a warning.

Does this mean that I need to enable an enforce property?

Warning not error, so still enforce: false. Error would be enforce: true

Got it.

Change 557034 had a related patch set uploaded (by Crutishnyk; owner: Crutishnyk):
[translatewiki@master] Update Huggle to use the new validator framework

https://gerrit.wikimedia.org/r/557034

gerritbot added a project: Patch-For-Review.Dec 13 2019, 2:47 PM

abi_ assigned this task to Crutishnyk.Dec 13 2019, 5:24 PM

Change 557034 merged by jenkins-bot:
[translatewiki@master] Update Huggle to use the new validator framework

https://gerrit.wikimedia.org/r/557034

jenkins-bot mentioned this in rGTWN22fadf37ddd0: Update Huggle to use the new validator framework.Dec 13 2019, 5:36 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2019, 6:11 PM