Page MenuHomePhabricator

Migrate Phabricator to the new validator framework
Closed, ResolvedPublic

Description

Migrate the existing checker / suggester code to instead use the new validator framework. We need to add,

  1. A validator to replicate - wikiParameterCheck. We can add a custom validator and use that instead of defining a regex everytime. Insertable but not enforced.
  2. Replace braceBalanceCheck with BraceBalanceValidator

We'll need to update the YAML configuration file located here - https://phabricator.wikimedia.org/diffusion/GTWN/browse/master/groups/

Documentation: https://www.mediawiki.org/wiki/Help:Extension:Translate/Validators
Example patch: https://gerrit.wikimedia.org/r/c/translatewiki/+/549930

Event Timeline

abi_ created this task.Nov 11 2019, 8:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 11 2019, 8:32 AM

Change 556475 had a related patch set uploaded (by Crutishnyk; owner: Crutishnyk):
[translatewiki@master] phabricator: Update Phabricator to the new validator framework

https://gerrit.wikimedia.org/r/556475

Change 556807 had a related patch set uploaded (by Crutishnyk; owner: Crutishnyk):
[mediawiki/extensions/Translate@master] messageValidators: Add WikiParameterValidator

https://gerrit.wikimedia.org/r/556807

Change 556807 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add WikiParameterValidator

https://gerrit.wikimedia.org/r/556807

Change 556475 merged by jenkins-bot:
[translatewiki@master] Update Phabricator to use the new validator framework

https://gerrit.wikimedia.org/r/556475

abi_ closed this task as Resolved.Dec 13 2019, 1:34 PM
abi_ claimed this task.

A custom validator - WikiParameter validator has been added and the configuration for the Phabricator project has been updated. These changes will be deployed to the translatewiki server next Wednesday. I've tested the validator and don't expect to have any issues during deployment, so resolving the task.

abi_ reassigned this task from abi_ to Crutishnyk.Dec 13 2019, 1:34 PM

Change 559096 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Remove insertable from BraceBalance validator

https://gerrit.wikimedia.org/r/559096

Change 559096 abandoned by Abijeet Patro:
Remove insertable from BraceBalance validator

Reason:
See Ib493aeadea0b04f8743ad1c8d553b26e286a651b

https://gerrit.wikimedia.org/r/559096