Migrate Phabricator to the new validator framework
Closed, ResolvedPublic
Actions

Description

Migrate the existing checker / suggester code to instead use the new validator framework. We need to add,

A validator to replicate - wikiParameterCheck. We can add a custom validator and use that instead of defining a regex everytime. Insertable but not enforced.
Replace braceBalanceCheck with BraceBalanceValidator

We'll need to update the YAML configuration file located here - https://phabricator.wikimedia.org/diffusion/GTWN/browse/master/groups/

Documentation: https://www.mediawiki.org/wiki/Help:Extension:Translate/Validators
Example patch: https://gerrit.wikimedia.org/r/c/translatewiki/+/549930

Details

Project	Branch	Lines +/-	Subject
translatewiki	master	+0 -1	Remove insertable from BraceBalance validator
translatewiki	master	+7 -8	Update Phabricator to use the new validator framework
mediawiki/extensions/Translate	master	+85 -1	Add WikiParameterValidator

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T195760 Language Annual Plan 2018-2019
Open	None	T204818 Language tools maintenance intervention: Improve the quality of translations for Translate extension
Resolved	abi_	T204568 Extend message checker framework to support errors that prevent saving
Resolved	abi_	T224025 Migrate existing projects to use the new Validator framework
Resolved	Crutishnyk	T237921 Migrate Phabricator to the new validator framework

Event Timeline

abi_ created this task.Nov 11 2019, 8:32 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 11 2019, 8:32 AM

abi_ added a parent task: T224025: Migrate existing projects to use the new Validator framework.Nov 11 2019, 8:32 AM

Related Google Code-in task: https://codein.withgoogle.com/dashboard/tasks/6215960596316160/

Ping: @Urbanecm

Urbanecm moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.Nov 26 2019, 4:42 PM

Change 556475 had a related patch set uploaded (by Crutishnyk; owner: Crutishnyk):
[translatewiki@master] phabricator: Update Phabricator to the new validator framework

https://gerrit.wikimedia.org/r/556475

gerritbot added a project: Patch-For-Review.Dec 11 2019, 9:17 PM

Change 556807 had a related patch set uploaded (by Crutishnyk; owner: Crutishnyk):
[mediawiki/extensions/Translate@master] messageValidators: Add WikiParameterValidator

https://gerrit.wikimedia.org/r/556807

Change 556807 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Add WikiParameterValidator

https://gerrit.wikimedia.org/r/556807

Change 556475 merged by jenkins-bot:
[translatewiki@master] Update Phabricator to use the new validator framework

https://gerrit.wikimedia.org/r/556475

A custom validator - WikiParameter validator has been added and the configuration for the Phabricator project has been updated. These changes will be deployed to the translatewiki server next Wednesday. I've tested the validator and don't expect to have any issues during deployment, so resolving the task.

abi_ reassigned this task from abi_ to Crutishnyk.Dec 13 2019, 1:34 PM

abi_ mentioned this in rGTWNd885585cac9c: Update Phabricator to use the new validator framework.Dec 13 2019, 1:35 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.11; 2019-12-17).Dec 13 2019, 2:01 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2019, 2:10 PM

Change 559096 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[translatewiki@master] Remove insertable from BraceBalance validator

https://gerrit.wikimedia.org/r/559096

Change 559096 abandoned by Abijeet Patro:
Remove insertable from BraceBalance validator

Reason:
See Ib493aeadea0b04f8743ad1c8d553b26e286a651b

https://gerrit.wikimedia.org/r/559096

Maintenance_bot removed a project: Patch-For-Review.Dec 18 2019, 3:10 PM