Page MenuHomePhabricator

Some property labels are not displayed on Item pages
Open, HighPublic

Description

Some property labels are not displayed on Item pages and show the P-number instead. See for example https://www.wikidata.org/wiki/Q12418#P195
Purging the page doesn't fix it.

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterConsider any type of empty value as uncached in SqlEntityInfoBuilder
mediawiki/extensions/Wikibase : wmf/1.35.0-wmf.5Cache SqlEntityInfoBuilder also based on term type
mediawiki/extensions/Wikibase : masterCache SqlEntityInfoBuilder also based on term type

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Nov 11, 2:28 PM

Some precision: apparently (from what I've seen) it appears only in English and French and only for the P195 property.

It's occurs whether I'm connected or unconnected, on all system and browser I tried (Ubuntu and Windows ; Mozilla Firefox, Edge and Chrome).

I just ran the rebuild term store for P195 and it fixed the issue (if you see it somewhere else, please purge the page). I ran it everywhere.

Mentioned in SAL (#wikimedia-operations) [2019-11-12T12:37:48Z] <Amir1> ladsgroup@mwmaint1002:~$ mwscript extensions/Wikibase/repo/maintenance/rebuildPropertyTerms.php --wiki=wikidatawiki --batch-size 100 (T237984)

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptTue, Nov 12, 12:38 PM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.
alaa_wmde added a subscriber: alaa_wmde.

@Lea_Lacroix_WMDE this should be solved. Anything else to look at from your side before we resolve?

Yep, just let me 1-2 days to ping people in case there are some left cases, and then you can close :)

Looks like this might be related?

Looks like this might be related?

Which page is this happening and did you try purging the cache (with action=purge on URL)

happens everywhere:

I have not tried clearing the cache.

...same result after clearing the cache.

seems to only affect "given name!"

I ran it again, it should be fixed now, let me know if it's happening again :(

Fixed on my side, thx!

a bit of a never-ending story this. Now it's moved on to family name ;) Happened around 15:00 Berlin time

also, unit names have stopped resolving. This started some time yesterday, don't know if that's related?

Ladsgroup removed Ladsgroup as the assignee of this task.Fri, Nov 15, 2:34 PM
Ladsgroup removed a project: User-Ladsgroup.

a bit of a never-ending story this. Now it's moved on to family name ;) Happened around 15:00 Berlin time

This basically means randomly the new term store empties the terms but doesn't put the new version (I don't know if the term store diff it or just remove everything and puts it back again. @alaa_wmde knows better). I can't check this properly now, I'm busy with debugging another set of issues.

also, unit names have stopped resolving. This started some time yesterday, don't know if that's related?

Can you file a bug for this? It might be related to the deployment of caching in SqlEntityInfoBuilder that I did. I will check that.

Can you file a bug for this? It might be related to the deployment of caching in SqlEntityInfoBuilder that I did. I will check that.

This literally stopped happening just after I mentioned it. Will file a bug if it reappears. Thx!

PKM added a subscriber: PKM.Sat, Nov 16, 2:27 AM

I’m seeing this bug now (units as Q numbers) even after purging.

@PKM Can you add the links of a few pages where this happens?

Addshore triaged this task as High priority.Mon, Nov 18, 2:59 PM
Ash_Crow added a subscriber: Ash_Crow.EditedMon, Nov 18, 5:21 PM

I don't know if it's related, but here https://www.wikidata.org/wiki/Wikidata:Property_proposal/YVNG_ID the labels are not displayed for the {{Q}} template, even after a purge. (I'm logged in, interface is in French, I use the last version of Firefox on Ubuntu 18.10)

Change 551861 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Cache SqlEntityInfoBuilder also based on term type

https://gerrit.wikimedia.org/r/551861

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptTue, Nov 19, 4:21 PM

Now I see it on "beats per minute" as well

Thanks everyone. Amir is on it. We hopefully have a fix soon.

I don't know if it's related, but here https://www.wikidata.org/wiki/Wikidata:Property_proposal/YVNG_ID the labels are not displayed for the {{Q}} template, even after a purge. (I'm logged in, interface is in French, I use the last version of Firefox on Ubuntu 18.10)

This and issues with unit is something the patch mentioned here would fix.

Regarding the issue with properties. When I looked at problematic ones, there wasn't any term recorded in the new term store for the properties which is weird because the code handling the new store doesn't remove everything when you edit the property, it removes needed ones only but I remembered the maintenance script to rebuild the term store actually removes the terms first and put them back again. So it's rather clear that the maintenance script sometimes fail to put the terms into the term store which also explains why you first saw it in P195 then in larger numbers (P734) and then again in larger numbers (~P2000) because the script doesn't have "--to-id" option (like the item ones) so I had to run it for everything higher than the given P-id.

I went through everything and couldn't find any property without label anymore. I feel this might be still happening for items once we switch to read new for those but I don't have any easy good way to fix all of the failed ones for items. One thing that we can do is to run a script on dumps and see what existing pages don't have any entries in wbt_item_terms table. It should not be super hard though (famous last words).

Change 551861 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Cache SqlEntityInfoBuilder also based on term type

https://gerrit.wikimedia.org/r/551861

Change 552493 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.5] Cache SqlEntityInfoBuilder also based on term type

https://gerrit.wikimedia.org/r/552493

Change 552493 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.5] Cache SqlEntityInfoBuilder also based on term type

https://gerrit.wikimedia.org/r/552493

The issue is still happening on https://www.wikidata.org/wiki/Q62286812 . Purging doesn't fix it. When making an edit to the statement, the labels are back. Can we do some kind of reload so people don't have to edit all the statements?

The issue is still happening on https://www.wikidata.org/wiki/Q62286812 . Purging doesn't fix it. When making an edit to the statement, the labels are back. Can we do some kind of reload so people don't have to edit all the statements?

I can't reproduce it, can you tell me which property to be exact?

Oh, then my edit fixed both. It's still happening in https://www.wikidata.org/wiki/Q62286808 for height and width

Oh, then my edit fixed both. It's still happening in https://www.wikidata.org/wiki/Q62286808 for height and width

purge fixed it. I'm sorry, we can't do much in this regard until parse cache expires (a month, edit or a purge)

OK cool, thanks for the answer, I think it's fine.

even newly created items have this issue still. Is that part of the deal/a known issue ?

Lydia_Pintscher reopened this task as Open.Wed, Nov 27, 3:45 PM

Reopening for investigation.

even newly created items have this issue still. Is that part of the deal/a known issue ?

What item is it?

I don't remember which that one was, but here's a fresh example https://www.wikidata.org/wiki/Q48789733

...this is what I see:

Mentioned in SAL (#wikimedia-operations) [2019-11-28T13:57:12Z] <Amir1> start of mwscript extensions/Wikibase/repo/maintenance/rebuildPropertyTerms.php --wiki=wikidatawiki --batch-size 5 (T237984)

As for the example above, this now seems fixed!

Let's wait for a week to see if anything breaks again

started happening again just now:

(from https://www.wikidata.org/wiki/Q76103943 )

started happening again just now:

(from https://www.wikidata.org/wiki/Q76103943 )

You needed to purge the item.

weird, it was newly created. Did you purge using the query string or the link in the UI?

Moebeus added a comment.EditedSun, Dec 1, 7:32 PM

something is definitely not all there. This now happens for all newly created family name properties, including ones copied from an item to another using javascript. Purging using the purge link does not work.

@Moebeus Can you add a link to the item when you add a screenshot? Thanks :)
Did you try Ctrl+Maj+R for purging?

Anyways, I agree with you that this is annoying, especially if it happens also on newly created items. We need to investigate again on this.

something is definitely not all there. This now happens for all newly created family name properties, including ones copied from an item to another using javascript. Purging using the purge link does not work.

So the thing is that the term wasn't there for a not-short period of time and it got its way to the ParserCache, you need to remake the pages with action=purge (clearing the client cache wouldn't fix it, we need to purge the server cache, one of them, or wait for a month for them to expire)

We spot-checked a number of newly created Items and couldn't find any issue in them now. If there are still cases that are not fixed with a purge please link to them here. Thanks! :)

We will leave this one open for another week or so ready to catch any more issues before resolving this task.

this problem has not gone away at all, it keeps moving around between different properties. A minor annoyance for me at the moment, but must be very confusing for new editors.

What is the item?

any item, but here's an example of an "old" item: https://www.wikidata.org/wiki/Q77413614
This does however apply to newly created items as well as existing ones. It also affects some other properties, like "record label":

Bob Dylan for reference:

I think I know what's causing it but given the nature of the problem (like the ones you mentioned, they all are fixed now), it's really hard to make sure that would fix it. I will make a patch and hopefully wait to see if that stops happening.

Moebeus added a comment.EditedFri, Dec 6, 12:18 AM

weird stuff this, I don't envy you trying to track it down. Here's another weird detail I just discovered: When the property labels won't display, they do show up with "fallback values" in another language in the revision history:


This is what it looks like on the item page:

the alternate language in this case ("platemerke" instead of "record label") is Norwegian. I have my UI lang set to English, but I speak Norwegian, don't know if this is helpful or not...
EDIT: The example item is https://www.wikidata.org/wiki/Q235931

Change 555461 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Consider any type of empty value as uncached in SqlEntityInfoBuilder

https://gerrit.wikimedia.org/r/555461