Page MenuHomePhabricator
Create Task
Maniphest T238053

puppet-compiler fails to compile production catalog for restbase2014
Closed, ResolvedPublic
Actions

Description

pcc fails to compile the current catalog for restbase2014, example run at https://puppet-compiler.wmflabs.org/compiler1002/19343/

Error:

Error: Failed to compile catalog for node restbase2014.codfw.wmnet: source sequence is illegal/malformed utf-8

puppet is fine in restbase2014 but it shows an extra message:

Info: Unable to serialize catalog to json, retrying with pson
WARNING: even though wmflib::secret exists it will not work untill we enable the rich_data configuration. If used the function will copy the base64 content to the destination instead of the binary file content Info: Unable to serialize catalog to json, retrying with pson

Details

SubjectRepoBranchLines +/-
puppet_compiler: update the puppet master --compile command to support psonoperations/puppetproduction+333 -0
cassandra: use wmflib::secret for binary filesoperations/puppetproduction+6 -2
Customize query in gerrit

Related Objects

Event Timeline

Vgutierrez created this task.Nov 12 2019, 10:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 12 2019, 10:21 AM
Peachey88 added a project: Puppet CI.Nov 12 2019, 10:22 AM
jbond added a comment.Nov 13 2019, 5:02 PM

This seems to be related to PUP-8187 the puppet master --compile option in puppet version 5.5 doesn't correctly support pson and would ultimately be resolved by T236481 or T236373. This should only effect nodes which have a catalogue that sends binary data which most commonly happens when a file has the source parameter set to some binary content. There is an experimental switch simlar to future_parser and ill try to test this and add support to pcc next week

gerritbot added a comment.Feb 3 2020, 3:50 PM

Change 569570 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] cassandra: use wmflib::secret for binary files

https://gerrit.wikimedia.org/r/569570

gerritbot added a project: Patch-For-Review.Feb 3 2020, 3:50 PM
gerritbot added a comment.Feb 5 2020, 1:04 PM

Change 569570 abandoned by Filippo Giunchedi:
cassandra: use wmflib::secret for binary files

Reason:
As per John, not viable ATM

https://gerrit.wikimedia.org/r/569570

Maintenance_bot removed a project: Patch-For-Review.Feb 5 2020, 1:10 PM
gerritbot added a comment.Feb 5 2020, 1:18 PM

Change 569570 restored by Filippo Giunchedi:
cassandra: use wmflib::secret for binary files

https://gerrit.wikimedia.org/r/569570

gerritbot added a comment.Feb 5 2020, 2:51 PM

Change 569570 merged by Filippo Giunchedi:
[operations/puppet@production] cassandra: use wmflib::secret for binary files

https://gerrit.wikimedia.org/r/569570

jbond updated the task description. (Show Details)Feb 5 2020, 4:25 PM
jbond updated the task description. (Show Details)
jbond updated the task description. (Show Details)
jbond updated the task description. (Show Details)
jbond updated the task description. (Show Details)
jbond added a comment.Feb 7 2020, 12:28 PM

possible patch to puppet untested and could be a bad idea https://phabricator.wikimedia.org/P10344

gerritbot added a comment.Feb 7 2020, 1:31 PM

Change 570889 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] puppet_compiler: update the puppet master --compile command to support pson

https://gerrit.wikimedia.org/r/570889

gerritbot added a project: Patch-For-Review.Feb 7 2020, 1:32 PM
gerritbot added a comment.Feb 10 2020, 12:32 PM

Change 570889 merged by Jbond:
[operations/puppet@production] puppet_compiler: update the puppet master --compile command to support pson

https://gerrit.wikimedia.org/r/570889

jbond added a comment.Feb 10 2020, 12:42 PM
In T238053#5859435, @jbond wrote:

possible patch to puppet untested and could be a bad idea https://phabricator.wikimedia.org/P10344

I have applied this patch to the compilers and PCC seems to be working again. Please reopen if you see similar issues

jbond closed this task as Resolved.Feb 10 2020, 12:47 PM
jbond mentioned this in T349291: Fix outstanding puppet 7 issues.Oct 20 2023, 2:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL