Page MenuHomePhabricator

Rollback claims to have reverted revision deletion
Closed, ResolvedPublic

Description

Author: mattbisanz

Description:
Screenshot of above link.

Using the (rollback) links in page history and the watchlist, I was able to successfully revert an edit that was hidden with revision deletion, even though I couldn't see the edit and the revert did not appear in my edit history.


Version: unspecified
Severity: minor
URL: http://en.wikipedia.org/w/index.php?title=User_talk:FloNight&action=rollback&token=631e1063ab0a51d0e1954a3972523af9%2B\

Attached:

Details

Reference
bz21814

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:50 PM
bzimport set Reference to bz21814.

To be clear, this is only an issue of poor error reporting. The rollback _says_ it is successful, but it doesn't actually revert the edits.

The correct behavior is displaying a message to the user that the rollback failed.

aaron added a comment.Dec 10 2009, 9:11 PM

Can't repro locally

I can reproduce this on my local copy.

(In reply to comment #0)

Using the (rollback) links in page history and the watchlist, I was able to
successfully revert an edit that was hidden with revision deletion, even though
I couldn't see the edit and the revert did not appear in my edit history.

You could revert it because the content of the edits you were reverting to and from were not deleted, so you could still see the diff between them (just not the diffs involving the intervening edit). In the later edit, only the username was suppressed.

(In reply to comment #1)

To be clear, this is only an issue of poor error reporting. The rollback _says_
it is successful, but it doesn't actually revert the edits.

The correct behavior is displaying a message to the user that the rollback
failed.

The rollback does actually work, in the case given it didn't show up in the page history as the rollback would have been a null edit.

Fixed in r60064