Page MenuHomePhabricator

Establish a process for renewing TLS certs for the 2 webhook controllers
Open, MediumPublic

Description

The validating admission webhooks running in the new version of Toolforge Kubernetes use certs generated using the certificates API in Kubernetes. That implies an expiration of one year. They need to be renewed via an automated or manually reviewed process that can be reliably used without a deep dive into that API every time.

Event Timeline

Bstorm added a subscriber: aborrero.

@aborrero set up a script for requesting certs at modules/toolforge/files/k8s/admin_scripts/wmcs-k8s-get-cert.sh that places certs in a tmpdir. The main difference here is that we need them in a Kubernetes secret (which can easily be generated from the files like in their individual scripts) and to restart the services.

The services also could use some prometheus instrumentation to tell our monitors about when their certs expire.

Bstorm triaged this task as Medium priority.Jan 22 2020, 10:29 PM
Bstorm added a comment.Apr 9 2020, 9:44 PM

For the time being this is basically just following the README directions to create certs...again. The script mentioned in https://phabricator.wikimedia.org/T215553#5674833 won't work for the controllers because they need a cert that validates their DNS.