Page MenuHomePhabricator

Message "apihelp-blogpage-param-pageName" should be in lowercase
Closed, ResolvedPublic

Description

In order of being able to upgrade grunt-banana-checker to its latest version, the message "apihelp-blogpage-param-pageName" should be in lowercase. That also means finding and replacing where the message is being used in the code itself I guess.

11:45:36 Running "banana:all" (banana) task
11:45:36 >> 1 message is not wholly lowercase.
11:45:36 >> Message "apihelp-blogpage-param-pageName" should be in lowercase.
11:45:36 Warning: Task "banana:all" failed. Use --force to continue.

Thank you.

Event Timeline

Restricted Application added a project: Social-Tools. · View Herald TranscriptNov 13 2019, 11:27 AM

To unblock the grunt-banana-checker upgrade, you could also disable the [requireLowerCase option](https://www.npmjs.com/package/grunt-banana-checker#requirelowercase) (probably [in the Gruntfile](https://www.npmjs.com/package/grunt-banana-checker#configure-the-grunt-plugin)).

Lucas_Werkmeister_WMDE added a subscriber: ashley.EditedNov 13 2019, 4:37 PM

Though in the long run I think it would be a good idea to actually rename this pageName parameter to all-lowercase pagename. (In fact, it’s already documented under that name on mediawiki.org.) To do this without suddenly breaking clients, you should probably declare both pagename and pageName in ApiBlogPage::getAllowedParams(), marking pageName as deprecated (PARAM_DEPRECATED => true), and read $params['pagename'] ?? $params['pageName'] in execute() (assuming the extension already requires PHP 7, otherwise ?? isn’t available); announce the change wherever you want and wait for however long you think is necessary (since this extension isn’t bound by MediaWiki’s formal deprecation policy); and eventually get rid of the pageName parameter.

ashley closed this task as Resolved.Jun 12 2020, 8:08 PM
ashley claimed this task.

The whole API module was removed in 6b108f850027baa93ba3bc7109e9671bc6f2271b so thus the message is also gone.