Page MenuHomePhabricator

Do not hardcode SMTP server address
Closed, ResolvedPublic



It's considered bad practice to hardcode things into an app, like which mailserver it should use.

Proposed solution

Move SMTP server address into a configuration file.

Student is expected to upload a patch against labs/tools/watch-translations repository at Wikimedia Gerrit. Student should claim Phabricator task while claiming task at the GCI site.



Related Gerrit Patches:
labs/tools/watch-translations : masterMove SMTP address to config file.

Event Timeline

Urbanecm created this task.Wed, Nov 13, 3:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Nov 13, 3:10 PM
IAmNetx claimed this task.Tue, Dec 3, 12:15 PM

Change 554274 had a related patch set uploaded (by IAmNetx; owner: IAmNetx):
[labs/tools/watch-translations@master] Move SMTP address to config file.

Change 554274 merged by jenkins-bot:
[labs/tools/watch-translations@master] Move SMTP address to config file.

Urbanecm closed this task as Resolved.Tue, Dec 3, 1:39 PM