Page MenuHomePhabricator

Propagate editing_session_id and oversampling flag from newcomer homepage to EditAttemptStep
Closed, ResolvedPublic

Description

When a user clicks on a suggested edit on Special:Homepage, the instrumentation token from the homepage needs to be propagated to the ensuing edit session's EditAttemptStep events as its editing_session_id. We also need to make sure that edit sessions following from suggested edit clicks are always instrumented (oversampled).

Details

Related Gerrit Patches:
mediawiki/extensions/GrowthExperiments : wmf/1.35.0-wmf.5Pass pageview token via task URL parameter, and use it in edit/help log
mediawiki/extensions/VisualEditor : wmf/1.35.0-wmf.5EditAttemptStep: Allow session ID override from query string or mw.config
mediawiki/extensions/WikiEditor : wmf/1.35.0-wmf.5EditAttemptStep: Allow session ID to be overridden through query string
mediawiki/extensions/MobileFrontend : wmf/1.35.0-wmf.5EditAttemptStep: Allow session ID override from query string or mw.config
mediawiki/extensions/WikimediaEvents : wmf/1.35.0-wmf.5EditAttemptStep: Allow other extensions to trigger oversampling
mediawiki/extensions/WikiEditor : masterEditAttemptStep: Allow session ID to be overridden through query string
mediawiki/extensions/WikimediaEvents : masterEditAttemptStep: Allow other extensions to trigger oversampling
mediawiki/extensions/VisualEditor : masterEditAttemptStep: Allow session ID override from query string or mw.config
mediawiki/extensions/GrowthExperiments : masterPass pageview token via task URL parameter, and use it in edit/help log
mediawiki/extensions/MobileFrontend : masterEditAttemptStep: Allow session ID override from query string or mw.config

Event Timeline

Catrope created this task.Wed, Nov 13, 7:41 PM

Change 550743 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/WikimediaEvents@master] EditAttemptStep: Allow other extensions to trigger oversampling

https://gerrit.wikimedia.org/r/550743

Change 550745 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/VisualEditor@master] EditAttemptStep: Allow session ID override from query string or mw.config

https://gerrit.wikimedia.org/r/550745

Change 550746 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/WikiEditor@master] EditAttemptStep: Allow session ID to be overridden through query string

https://gerrit.wikimedia.org/r/550746

Change 550747 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/MobileFrontend@master] EditAttemptStep: Allow session ID override from query string or mw.config

https://gerrit.wikimedia.org/r/550747

Change 549915 had a related patch set uploaded (by Catrope; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Pass pageview token via task URL parameter, and use it in edit/help log

https://gerrit.wikimedia.org/r/549915

Change 550743 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] EditAttemptStep: Allow other extensions to trigger oversampling

https://gerrit.wikimedia.org/r/550743

Change 550746 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] EditAttemptStep: Allow session ID to be overridden through query string

https://gerrit.wikimedia.org/r/550746

LGoto moved this task from Triage to Tracking on the Product-Analytics board.Fri, Nov 15, 6:08 PM

Change 550747 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] EditAttemptStep: Allow session ID override from query string or mw.config

https://gerrit.wikimedia.org/r/550747

Change 550745 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] EditAttemptStep: Allow session ID override from query string or mw.config

https://gerrit.wikimedia.org/r/550745

Change 549915 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Pass pageview token via task URL parameter, and use it in edit/help log

https://gerrit.wikimedia.org/r/549915

Change 551925 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.5] EditAttemptStep: Allow session ID override from query string or mw.config

https://gerrit.wikimedia.org/r/551925

Change 551926 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/WikimediaEvents@wmf/1.35.0-wmf.5] EditAttemptStep: Allow other extensions to trigger oversampling

https://gerrit.wikimedia.org/r/551926

Change 551927 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/WikiEditor@wmf/1.35.0-wmf.5] EditAttemptStep: Allow session ID to be overridden through query string

https://gerrit.wikimedia.org/r/551927

Change 551929 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/MobileFrontend@wmf/1.35.0-wmf.5] EditAttemptStep: Allow session ID override from query string or mw.config

https://gerrit.wikimedia.org/r/551929

Change 551930 had a related patch set uploaded (by Catrope; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.5] Pass pageview token via task URL parameter, and use it in edit/help log

https://gerrit.wikimedia.org/r/551930

Change 551926 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.35.0-wmf.5] EditAttemptStep: Allow other extensions to trigger oversampling

https://gerrit.wikimedia.org/r/551926

Change 551929 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.35.0-wmf.5] EditAttemptStep: Allow session ID override from query string or mw.config

https://gerrit.wikimedia.org/r/551929

Change 551927 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@wmf/1.35.0-wmf.5] EditAttemptStep: Allow session ID to be overridden through query string

https://gerrit.wikimedia.org/r/551927

Change 551925 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.5] EditAttemptStep: Allow session ID override from query string or mw.config

https://gerrit.wikimedia.org/r/551925

Change 551930 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.5] Pass pageview token via task URL parameter, and use it in edit/help log

https://gerrit.wikimedia.org/r/551930

Mentioned in SAL (#wikimedia-operations) [2019-11-19T23:55:31Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/WikimediaEvents/: EditAttemptStep: Allow other extensions to trigger oversampling (T238249) (duration: 00m 53s)

Mentioned in SAL (#wikimedia-operations) [2019-11-19T23:58:03Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/MobileFrontend/: EditAttemptStep: Allow overriding session ID (T238249) (duration: 00m 53s)

Mentioned in SAL (#wikimedia-operations) [2019-11-20T00:00:56Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/WikiEditor/: EditAttemptStep: Allow overriding session ID (T238249) (duration: 00m 54s)

Mentioned in SAL (#wikimedia-operations) [2019-11-20T00:02:33Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/VisualEditor/: EditAttemptStep: Allow overriding session ID (T238249) (duration: 00m 52s)

Mentioned in SAL (#wikimedia-operations) [2019-11-20T00:06:07Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/GrowthExperiments/: Pass token as editing_session_id for suggested edits (T238249) (duration: 00m 53s)

@Etonkovidova -- instrumentation task ready to be QAed.

Looks like the Growth-Team is working on this so the Editing-team is moving this to external.

Checked in betalabs - HomepageModule homepage_pageview_token will match EditAttmeptStep:editing_session_id when a user clicks on Suggested edits' article.

MMiller_WMF closed this task as Resolved.Tue, Dec 10, 2:14 AM

I have been successfully using this. Thank you!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptTue, Dec 10, 2:14 AM