When a user clicks on a suggested edit on Special:Homepage, the instrumentation token from the homepage needs to be propagated to the ensuing edit session's EditAttemptStep events as its editing_session_id. We also need to make sure that edit sessions following from suggested edit clicks are always instrumented (oversampled).
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | MMiller_WMF | T227728 [EPIC] Growth: Newcomer tasks 1.0 | |||
| Resolved | MMiller_WMF | T230068 Newcomer tasks: instrumentation | |||
| Resolved | Tgr | T235931 Newcomer tasks: code for instrumentation | |||
| Resolved | Catrope | T238249 Propagate editing_session_id and oversampling flag from newcomer homepage to EditAttemptStep |
Event Timeline
Comment Actions
Change 550743 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/WikimediaEvents@master] EditAttemptStep: Allow other extensions to trigger oversampling
Comment Actions
Change 550745 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/VisualEditor@master] EditAttemptStep: Allow session ID override from query string or mw.config
Comment Actions
Change 550746 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/WikiEditor@master] EditAttemptStep: Allow session ID to be overridden through query string
Comment Actions
Change 550747 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/MobileFrontend@master] EditAttemptStep: Allow session ID override from query string or mw.config
Comment Actions
Change 549915 had a related patch set uploaded (by Catrope; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Pass pageview token via task URL parameter, and use it in edit/help log
Comment Actions
Change 550743 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] EditAttemptStep: Allow other extensions to trigger oversampling
Comment Actions
Change 550746 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] EditAttemptStep: Allow session ID to be overridden through query string
Comment Actions
Change 550747 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] EditAttemptStep: Allow session ID override from query string or mw.config
Comment Actions
Change 550745 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] EditAttemptStep: Allow session ID override from query string or mw.config
Comment Actions
Change 549915 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Pass pageview token via task URL parameter, and use it in edit/help log
Comment Actions
Change 551925 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.5] EditAttemptStep: Allow session ID override from query string or mw.config
Comment Actions
Change 551926 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/WikimediaEvents@wmf/1.35.0-wmf.5] EditAttemptStep: Allow other extensions to trigger oversampling
Comment Actions
Change 551927 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/WikiEditor@wmf/1.35.0-wmf.5] EditAttemptStep: Allow session ID to be overridden through query string
Comment Actions
Change 551929 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/MobileFrontend@wmf/1.35.0-wmf.5] EditAttemptStep: Allow session ID override from query string or mw.config
Comment Actions
Change 551930 had a related patch set uploaded (by Catrope; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.5] Pass pageview token via task URL parameter, and use it in edit/help log
Comment Actions
Change 551926 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.35.0-wmf.5] EditAttemptStep: Allow other extensions to trigger oversampling
Comment Actions
Change 551929 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.35.0-wmf.5] EditAttemptStep: Allow session ID override from query string or mw.config
Comment Actions
Change 551927 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@wmf/1.35.0-wmf.5] EditAttemptStep: Allow session ID to be overridden through query string
Comment Actions
Change 551925 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.5] EditAttemptStep: Allow session ID override from query string or mw.config
Comment Actions
Change 551930 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.5] Pass pageview token via task URL parameter, and use it in edit/help log
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2019-11-19T23:55:31Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/WikimediaEvents/: EditAttemptStep: Allow other extensions to trigger oversampling (T238249) (duration: 00m 53s)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2019-11-19T23:58:03Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/MobileFrontend/: EditAttemptStep: Allow overriding session ID (T238249) (duration: 00m 53s)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2019-11-20T00:00:56Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/WikiEditor/: EditAttemptStep: Allow overriding session ID (T238249) (duration: 00m 54s)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2019-11-20T00:02:33Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/VisualEditor/: EditAttemptStep: Allow overriding session ID (T238249) (duration: 00m 52s)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2019-11-20T00:06:07Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/GrowthExperiments/: Pass token as editing_session_id for suggested edits (T238249) (duration: 00m 53s)
Comment Actions
Looks like the Growth-Team is working on this so the Editing-team is moving this to external.
Comment Actions
Checked in betalabs - HomepageModule homepage_pageview_token will match EditAttmeptStep:editing_session_id when a user clicks on Suggested edits' article.