Page MenuHomePhabricator
Create Task
Maniphest T238278

Fix postal code field when not showing city or state
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Since we went to the top-labeled fields, the zip field looks funky for Adyen, where it's not accompanied by a city and state field. Fix it to be full width with the label above.

Screenshot from 2019-11-13 18-21-21.png (652×555 px, 29 KB)

Details

SubjectRepoBranchLines +/-
Fix width of lone address fields without going wigglymediawiki/extensions/DonationInterfacemaster+4 -3
Fix width of lone address fieldsmediawiki/extensions/DonationInterfacemaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Nov 13 2019, 11:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 13 2019, 11:24 PM
Pcoombe subscribed.Nov 14 2019, 1:40 PM

T236077: City field and label positioned wrong on India form is something similar

gerritbot added a comment.Nov 14 2019, 3:32 PM

Change 550861 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Fix width of lone address fields

https://gerrit.wikimedia.org/r/550861

gerritbot added a project: Patch-For-Review.Nov 14 2019, 3:32 PM
gerritbot added a comment.Nov 14 2019, 3:54 PM

Change 550861 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Fix width of lone address fields

https://gerrit.wikimedia.org/r/550861

Maintenance_bot removed a project: Patch-For-Review.Nov 14 2019, 4:10 PM
• DStrine added a project: Fundraising Sprint A Wrinkle in Timezones.Nov 14 2019, 5:57 PM
• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.
gerritbot added a comment.Nov 14 2019, 7:05 PM

Change 550911 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Fix width of lone address fields without going wiggly

https://gerrit.wikimedia.org/r/550911

gerritbot added a project: Patch-For-Review.Nov 14 2019, 7:05 PM
Ejegg claimed this task.Nov 15 2019, 12:10 AM
Ejegg triaged this task as Medium priority.
Ejegg set the point value for this task to 1.
Ejegg moved this task from Backlog to Review on the Fundraising Sprint A Wrinkle in Timezones board.
gerritbot added a comment.Nov 18 2019, 5:57 PM

Change 550911 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Fix width of lone address fields without going wiggly

https://gerrit.wikimedia.org/r/550911

Maintenance_bot removed a project: Patch-For-Review.Nov 18 2019, 6:11 PM
Ejegg moved this task from Review to Deployed on the Fundraising Sprint A Wrinkle in Timezones board.Nov 18 2019, 7:30 PM
Ejegg closed this task as Resolved.Nov 18 2019, 11:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL