Page MenuHomePhabricator
Create Task
Maniphest T238279

Newcomer tasks: arrows are different distances from card on Mobile
Open, Needs TriagePublic
Actions

Assigned To
None
Authored By
MMiller_WMF
Nov 13 2019, 11:27 PM
Tags
Referenced Files
F32378476: image.png
Oct 8 2020, 5:29 PM
F32378472: image.png
Oct 8 2020, 5:28 PM
F32378474: image.png
Oct 8 2020, 5:28 PM
F31546140: image.png
Feb 3 2020, 4:22 PM
F31520284: Screen Shot 2020-01-21 at 4.10.18 PM.png
Jan 22 2020, 12:10 AM
F31122823: image.png
Nov 21 2019, 5:37 PM
F31122922: image.png
Nov 21 2019, 5:37 PM
F31117764: Capture.PNG
Nov 21 2019, 1:41 AM
View All 9 Files
Subscribers
Aklapper
• Catrope
• Cntlsn
Dyolf77_WMF
Etonkovidova
JTannerWMF
kostajh
View All 17 Subscribers

Description

@PPham noticed that the "forward" and "back" arrows next to the suggested edit cards are slightly different distances from the card. The "forward" arrow is closer than the back arrow:

image.png (209×536 px, 21 KB)

Both arrows should only be 16px from the card:

image.png (850×1 px, 673 KB)

Details

SubjectRepoBranchLines +/-
Fix suggested edits arrow positioningmediawiki/extensions/GrowthExperimentsmaster+6 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

MMiller_WMF created this task.Nov 13 2019, 11:27 PM
MMiller_WMF moved this task from Inbox to Upcoming Work on the Growth-Team board.
MMiller_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Nov 14 2019, 12:01 AM
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
Trizek-WMF added a project: User-PPham.Nov 15 2019, 3:42 PM
PPham moved this task from Backlog to Cần để ý on the User-PPham board.Nov 20 2019, 1:40 AM
PPham added a comment.Nov 21 2019, 1:41 AM

It's the same in the desktop version now...

Capture.PNG (473×639 px, 24 KB)

RHo mentioned this in T238598: Newcomer tasks: Display article cards with more information when the Suggested edits module is wide.Nov 21 2019, 5:37 PM
In T238279#5680536, @PPham wrote:

It's the same in the desktop version now...

Capture.PNG (473×639 px, 24 KB)

Unfortunately it is still not quite evenly spaced:

image.png (1×1 px, 87 KB)

I think this is being caused by a negative margin-left on the class .oo-ui-buttonElement-frameless.oo-ui-iconElement:first-child
image.png (1×1 px, 264 KB)

Also, the arrows should always be contained within the module even when it is extremely narrow as shown in these screenshots. I have added this restyling for narrow width SE module to the same responsive article cards ticket T238598

MMiller_WMF edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).Nov 26 2019, 5:51 PM
RHo mentioned this in T238280: Newcomer tasks: mobile module styling issues.Dec 13 2019, 6:59 PM
MMiller_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jan 15 2020, 6:52 PM
Tgr claimed this task.Jan 17 2020, 3:57 AM
Tgr moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Jan 17 2020, 4:25 AM

Change 565455 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix suggested edits arrow positioning

https://gerrit.wikimedia.org/r/565455

gerritbot added a project: Patch-For-Review.Jan 17 2020, 4:25 AM
Tgr moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 17 2020, 4:46 AM
gerritbot added a comment.Jan 17 2020, 2:39 PM

Change 565455 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix suggested edits arrow positioning

https://gerrit.wikimedia.org/r/565455

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 17 2020, 2:59 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 17 2020, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 17 2020, 3:10 PM
Etonkovidova moved this task from QA to Design Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 22 2020, 12:10 AM

Checked in betalabs - the arrows are positioned equally

Screen Shot 2020-01-21 at 4.10.18 PM.png (616×460 px, 118 KB)

In T238279#5682099, @RHo wrote:
In T238279#5680536, @PPham wrote:

Also, the arrows should always be contained within the module even when it is extremely narrow as shown in these screenshots. I have added this restyling for narrow width SE module to the same responsive article cards ticket T238598

It's also done.

Tgr added a comment.Jan 23 2020, 6:26 AM

Kosta pointed out on the patch that there's still a tiny difference (the left arrow is 2px farther).

RHo moved this task from Design Review to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 3 2020, 4:22 PM
In T238279#5825672, @Tgr wrote:

Kosta pointed out on the patch that there's still a tiny difference (the left arrow is 2px farther).

Yes there is still a discrepancy - it looks like this may be due to uneven positioning being added on the span element of the arrows?

image.png (1×1 px, 321 KB)

Urbanecm edited subscribers, added: • Urbanecm_WMF; removed: Urbanecm.Aug 22 2020, 6:51 PM
MMiller_WMF edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).Oct 8 2020, 4:52 AM

@RHo -- do we still have this issue? If not, please resolve.

RHo added a comment.Oct 8 2020, 5:28 PM
In T238279#6527755, @MMiller_WMF wrote:

@RHo -- do we still have this issue? If not, please resolve.

This is still an issue on Mobile:

image.png (1×1 px, 157 KB)

Also, I think there is a regression elsewhere too because now on Mobile the arrows are further away from the card than expected:

image.png (850×1 px, 673 KB)
(expected Zeplin mock)

RHo renamed this task from Newcomer tasks: arrows are different distances from card to Newcomer tasks: arrows are different distances from card on Mobile.Oct 8 2020, 5:29 PM
RHo updated the task description. (Show Details)
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM
Tgr removed Tgr as the assignee of this task.Feb 7 2022, 12:47 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits