Page MenuHomePhabricator

When sitewide blocked, cannot undelete/restore own User_talk, even if not blocked from own User_talk
Closed, ResolvedPublicBUG REPORT

Description

What is the problem?

An admin who is sitewide blocked, but not blocked from their own User_talk, cannot restore their User_talk if it has been deleted.

I believe the logic effecting this is here. Only checks whether the user is sitewide blocked, ignoring what the page they are trying to restore is.

Found as part of testing T227412.

Steps to reproduce problem
  1. Login as $admin with undelete rights; delete their own User_talk (User_talk:$admin)
  2. Block $admin sitewide, but not from User_talk (e.g. in the Special:Block form, "Editing their own talk page" is unchecked)
  3. As $admin, go to Special:Undelete/User_talk:$admin

Expected behavior: You see a form allowing you to "Restore revisions"
Observed behavior: The rest of the page loads, but the form does not

Event Timeline

Change 555717 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Allow blocked admin to restore their talkpage if not blocked from it

https://gerrit.wikimedia.org/r/555717

Ammarpad triaged this task as Medium priority.

Change 555717 merged by jenkins-bot:
[mediawiki/core@master] Allow blocked admin to restore their (deleted) talkpage if not blocked from it

https://gerrit.wikimedia.org/r/555717