Retried-load results in document showing twice
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Nov 14 2019, 2:55 PM

Description

If the article fails to load, we give the user the option to retry:

If the second try succeeds, we show the read mode and the edit beneath it:

A retry loop can be tested with the following patch:

diff --git a/modules/ve-mw/init/targets/ve.init.mw.ArticleTarget.js b/modules/ve-mw/init/targets/ve.init.mw.ArticleTarget.js
index c129712fb..e640a7d61 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ArticleTarget.js
@@ -354,7 +354,8 @@ ve.init.mw.ArticleTarget.prototype.loadSuccess = function ( response ) {
        var mode, section,
                data = response ? ( response.visualeditor || response.visualeditoredit ) : null;
 
-       if ( !data || typeof data.content !== 'string' ) {
+       if ( !this.retried ) {
+               this.retried = true;
                this.loadFail( 've-api', 'No HTML content in response from server' );
        } else if ( response.veMode && response.veMode !== this.getDefaultMode() ) {
                this.loadFail( 've-mode', 'Tried to load "' + response.veMode + '" data ' +

Details

	Subject	Repo	Branch	Lines +/-
	Don't reject activatingDeferred on loadFail	mediawiki/extensions/VisualEditor	master	+1 -2

Customize query in gerrit

Event Timeline

Esanders created this task.Nov 14 2019, 2:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 14 2019, 2:55 PM

Looks like the ve-active class isn't added to the body. This is the one that hides the read article.

Esanders updated the task description. (Show Details)Nov 14 2019, 3:08 PM

Change 550858 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Don't reject activatingDeferred on loadFail

https://gerrit.wikimedia.org/r/550858

gerritbot added a project: Patch-For-Review.Nov 14 2019, 3:24 PM

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Nov 14 2019, 3:24 PM

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

I've seen bug reports in the past where VE was loaded along side other content, such as the classic WikiEditor, and I imagine this is the cause. Do you remember these @Whatamidoing-WMF ?

I vaguely recall a case where a similar problem was caused by unbalanced HTML in some overridden localisation message (it would have caused the WT editor to be inside the wrong element, and therefore not be hidden), but I can't find that task either.

Change 550858 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Don't reject activatingDeferred on loadFail

https://gerrit.wikimedia.org/r/550858

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Nov 28 2019, 8:01 PM

Reproduction steps (without messing with the code, and without the server being broken somehow, which is the usual cause of failed loading):

Open a page in read mode
Open the editor
Close the editor without reloading the page (e.g. press Escape key on the keyboard)
In your browser's developer tools, enable "Offline" mode (or turn off your Wi-Fi :) )
Try opening the editor again – it will fail
In your browser's developer tools, disable "Offline" mode (or turn on your Wi-Fi)
Click "OK" to retry – editor should load

Note: it is necessary to open and close the editor first (step 2-3), because otherwise the loading will fail in a different way, as the editor code won't be loaded. That's probably also a bug…

Also, if I click "Cancel" in this popup, I end up in a broken mode where the editing toolbar is visible, but the read-mode uneditable content is showing.

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Nov 28 2019, 8:06 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 28 2019, 8:10 PM

JTannerWMF added a project: Editing QA.Jan 7 2020, 5:41 PM

JTannerWMF edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed VisualEditor (Current work).Feb 4 2020, 11:14 PM

JTannerWMF moved this task from Needs Discussion / Investigation to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.

matmarex added a project: VisualEditor.Feb 5 2020, 1:04 AM

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Feb 12 2020, 5:22 PM

Esanders claimed this task.Jun 4 2020, 2:49 PM

MBinder_WMF edited projects, added Editing-team (Kanban Board); removed Editing-team (Q3 2019-2020 Kanban Board).Jul 9 2020, 4:47 PM

JTannerWMF moved this task from Incoming to QA on the Editing-team (Kanban Board) board.Jul 9 2020, 4:48 PM

@ppelberg to check to see if this is still and issue based on the steps in Bartosz's comment

In T238332#6565723, @JTannerWMF wrote:

@ppelberg to check to see if this is still and issue based on the steps in Bartosz's comment

This is working for me. VE loads after clicking the "Try again" button in the dialog [i] that surfaces after completing Step 5 described in T238332#5700721.

Screen Shot 2020-10-21 at 6.48.20 PM.png (408×646 px, 92 KB)

• ppelberg closed this task as Resolved.Oct 22 2020, 1:49 AM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 22 2020, 1:49 AM

	F32410664: Screen Shot 2020-10-21 at 6.48.20 PM.png
	Oct 22 2020, 1:49 AM

Retried-load results in document showing twiceClosed, ResolvedPublicActions

Description

Details

Event Timeline

Retried-load results in document showing twice
Closed, ResolvedPublic
Actions