Page MenuHomePhabricator

ve.ce.TableEnterKeyDownHandler unit test failing on Mac
Closed, ResolvedPublic

Description

Test failing due to discrepancy between CMD+ENTER and CTRL+ENTER

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterUpdate VE core submodule to master (c6b5e46fa)
VisualEditor/VisualEditor : masterve.ce.TableEnterKeyDownHandler: unit test failing on Mac

Event Timeline

marcella created this task.Nov 14 2019, 5:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 14 2019, 5:41 PM

Change 550908 had a related patch set uploaded (by Marcella L. Florence; owner: Marcella L. Florence):
[VisualEditor/VisualEditor@master] ve.ce.TableEnterKeyDownHandler: unit test failing on Mac

https://gerrit.wikimedia.org/r/550908

Change 550908 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ce.TableEnterKeyDownHandler: unit test failing on Mac

https://gerrit.wikimedia.org/r/550908

Change 552087 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c6b5e46fa)

https://gerrit.wikimedia.org/r/552087

Change 552087 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c6b5e46fa)

https://gerrit.wikimedia.org/r/552087

JTannerWMF added a subscriber: JTannerWMF.

Looks like @marcella is working on this so I am moving tot he current work board

matmarex added a subscriber: matmarex.

I think it's all done, in fact, but we forgot to move it.

ppelberg closed this task as Resolved.Dec 24 2019, 6:18 PM