If an img tag is missing a closing slash then the parser hook isn't called
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Meisoda22
	Nov 15 2019, 3:35 AM

Description

I'm upgrading my custom site from MediaWiki 1.25 to 1.33 and now in my custom skin if I call

$parser->setHook( 'img', 'MyClass::ImgRender' );

it still works for img tags that have a closing slash: <img src="...png"/>
But the hook is no longer called for <img src="...png"> without a closing slash.
In MediaWiki 1.25 it worked for both.

Related Objects

Mentioned Here: T48443: Sanitizer fails to include image tags if incorrectly written as closed/void tags <img src= />
T134423: Deprecate nonstandard behavior of self-closed HTML tags in wikitext.

Event Timeline

Meisoda22 created this task.Nov 15 2019, 3:35 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2019, 3:35 AM

Meisoda22 updated the task description. (Show Details)Nov 15 2019, 3:42 AM

Meisoda22 added projects: MediaWiki-Parser, ParserFunctions, Parsing-Team--ARCHIVED.Nov 15 2019, 9:34 AM

Hi @Meisoda22, thanks for taking the time to report this and welcome to Wikimedia Phabricator!

Wondering if T48443 / T134423 (though that's about non-void tags only) are slightly related.

Hi @Aklapper . Thank you. I imagine that in practice they may be related within the code, since they both occur during parsing. But I think that at least in theory they're really two different things.

If an img tag is missing a closing slash then the parser hook isn't calledOpen, Needs TriagePublicActions

Description

Related Objects

Event Timeline

If an img tag is missing a closing slash then the parser hook isn't called
Open, Needs TriagePublic
Actions