Maniphest T238440

iOS 13 iPad Pro - Black bars on the sides of the editor details on Edit Compare on sepia and dark themes
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ABorbaWMF
	Nov 15 2019, 7:44 PM

Tags

Referenced Files

	F31091676: IMG_D06727E3B9BD-1.jpeg
	Nov 15 2019, 7:44 PM

Subscribers

Description

tested on 6.5.0 (1690)

Steps:

Using sepia or dark themes and on iPad
Go to an article history
Tap compare
Select two editors and compare them

Expected:
Not sure

Actual:
There are black bars to the left and right of the editor details

IMG_D06727E3B9BD-1.jpeg (2×2 px, 428 KB)

Event Timeline

ABorbaWMF created this task.Nov 15 2019, 7:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2019, 7:44 PM

LGoto triaged this task as Medium priority.Nov 18 2019, 7:37 PM

LGoto added a project: iOS-app-v6.5-Squid-On-A-Tandem-Bike.

LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Nov 18 2019, 7:40 PM

• JMinor lowered the priority of this task from Medium to Low.Nov 18 2019, 7:46 PM

• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.

Tsevener claimed this task.Nov 20 2019, 2:06 AM

Tsevener moved this task from Ready for Development to Doing on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.

https://github.com/wikimedia/wikipedia-ios/pull/3348

Tsevener moved this task from Doing to Needs Code Review on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 20 2019, 7:50 PM

Tsevener moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 21 2019, 8:57 PM

Tsevener moved this task from Waiting for Build to Needs Design Review on the iOS-app-v6.5-Squid-On-A-Tandem-Bike board.Nov 22 2019, 2:32 AM

Looking good! Thanks for this fix @Tsevener!

Looks good on 6.5.0 (1699)

• JMinor closed this task as Resolved.Dec 2 2019, 6:51 PM