Page MenuHomePhabricator

Direct link generator to reports in Superset has the incorrect hostname
Open, HighPublic3 Story PointsBUG REPORT

Description

Steps to Reproduce:
Generate a report in Superset. In the upper-right hand corner, click the link generator.

Actual Results:
Link is populated with http://localhost:9080/r/102

Expected Results:
Link should be https://superset.wikimedia.org/r/102

Details

Related Gerrit Patches:

Event Timeline

kzimmerman moved this task from Triage to Tracking on the Product-Analytics board.
Ottomata assigned this task to elukey.Mon, Nov 18, 4:38 PM
Ottomata triaged this task as High priority.
Ottomata added a project: Analytics-Kanban.
Ottomata moved this task from Incoming to Smart Tools for Better Data on the Analytics board.

Hi Kate! Thanks for the report, I wasn't aware of this functionality..

I found https://github.com/apache/incubator-superset/pull/4760/files#diff-ac978615a4f22c4fad4d01f39e1d4595R752, and I think that Superset's code uses the Request Host header (in this case localhost since we have a webserver in front of Superset) to compose the short link, it doesn't seem to be a configuration issue. I'll try to do more research and if I don't find anything I'll open a feature request to upstream.

Thanks for looking into this, Luca!

One other note is that, in an earlier version of Superset, the link generator worked properly. I don't recall exactly which version that is, but I have links that we generated in December 2018.

Ah interesting! In a few days I should be able to test the new version, 0.35.1, I'll make sure to see if the report generator works!

Change 552065 had a related patch set uploaded (by Elukey; owner: Elukey):
[operations/puppet@production] superset: add ProxyPreserveHost in httpd to avoid broken report generation

https://gerrit.wikimedia.org/r/552065

Change 552065 merged by Elukey:
[operations/puppet@production] superset: add ProxyPreserveHost in httpd to avoid broken report generation

https://gerrit.wikimedia.org/r/552065

@kzimmerman should work now, please check when you have a moment to confirm :)

elukey set the point value for this task to 3.Wed, Nov 20, 1:40 PM
elukey moved this task from Next Up to In Progress on the Analytics-Kanban board.
mforns moved this task from In Code Review to Done on the Analytics-Kanban board.