Add discussion button appears in talk pages which does not have wikitext content model
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Masumrezarock100
	Nov 16 2019, 2:58 PM

Project Tags

Referenced Files

	F31298218: wikitext.png
	Nov 26 2019, 10:49 PM

	F31095379: Screenshot_20191117-142048.png
	Nov 17 2019, 8:52 AM

	F31093330: Screenshot_20191116-203018.png
	Nov 16 2019, 3:02 PM

Subscribers

View All 11 Subscribers

Description

The giant Add discussion button and "There are no discussions on this page" message appears on pages in talk namespaces even when content model is not wikitext.

Steps to Reproduce:

Go to a page in one of the talk namespace.
Change it's content model from Wikitext to something else.

Actual Results:

The big Add discussion button is displayed even if the page content model is not wikitext. And a message stating "There are no discussions on this page" is displayed.

Expected Results:

The big Add discussion button is not shown if the page content model is not wikitext. No message appears.

Screenshot

Screenshot of https://commons.m.wikimedia.beta.wmflabs.org/wiki/Talk:Test when the content model of the page is json.

QA steps

Go to https://commons.m.wikimedia.beta.wmflabs.org/wiki/Talk:Test
Ensure that there is not a "There are no discussions on this page" message or "Active discussions" message anywhere on the page.
Ensure that there is not a "Add discussion" button on the page.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Make talk page explained message only appear on wikitext content model talk pages	Nray	mediawiki/skins/MinervaNeue	master	+4 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T232593 [EPIC] Transfer certain AMC functionality to all logged-in users
Resolved		ovasileva	T232594 Add article and discussion tabs to all logged-in users on mobile
Resolved		Jdlrobson	T230695 Render talk page as a tab (rather than a modal)
Resolved	BUG REPORT	ovasileva	T238474 Add discussion button appears in talk pages which does not have wikitext content model

Event Timeline

Masumrezarock100 created this task.Nov 16 2019, 2:58 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptNov 16 2019, 2:58 PM

Masumrezarock100 removed projects: User-notice, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 16 2019, 2:59 PM

Masumrezarock100 updated the task description. (Show Details)Nov 16 2019, 3:02 PM

Masumrezarock100 updated the task description. (Show Details)Nov 16 2019, 3:05 PM

Masumrezarock100 renamed this task from Add discussion button appears in talk page which content model is not wikitext to Add discussion button appears in talk pages which does not have wikitext content model.Nov 16 2019, 3:16 PM

Masumrezarock100 updated the task description. (Show Details)

Is this the same as T237589 ? I think they have the same underlying problem

In T238474#5668952, @Jdlrobson wrote:

Is this the same as T237589 ? I think they have the same underlying problem

That's only for flow talk pages. Isn't it?

Ammarpad updated the task description. (Show Details)Nov 16 2019, 5:34 PM

Masumrezarock100 updated the task description. (Show Details)Nov 16 2019, 6:10 PM

Masumrezarock100 updated the task description. (Show Details)

Masumrezarock100 updated the task description. (Show Details)Nov 16 2019, 6:16 PM

@Isarra In timeless skin, I am seeing a "New topic" hyperlink in talk pages which does not have wikitext content model.

Screenshot_20191117-142048.png (960×480 px, 36 KB)

In T238474#5668967, @Masumrezarock100 wrote:

In T238474#5668952, @Jdlrobson wrote:

Is this the same as T237589 ? I think they have the same underlying problem

That's only for flow talk pages. Isn't it?

No. The fix will handle anything that's not the wikitext content model.

In T238474#5669510, @Jdlrobson wrote:

In T238474#5668967, @Masumrezarock100 wrote:

In T238474#5668952, @Jdlrobson wrote:

Is this the same as T237589 ? I think they have the same underlying problem

That's only for flow talk pages. Isn't it?

No. The fix will handle anything that's not the wikitext content model.

Then it's the same.

Jdlrobson moved this task from Needs Analysis to Needs QA on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q2) board.Nov 21 2019, 6:32 PM

Change 552908 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/skins/MinervaNeue@master] Make talk page explained message only appear on wikitext content model talk pages

https://gerrit.wikimedia.org/r/552908

gerritbot added a project: Patch-For-Review.Nov 25 2019, 10:42 PM

Change 552908 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Make talk page explained message only appear on wikitext content model talk pages

https://gerrit.wikimedia.org/r/552908

• nray assigned this task to Edtadros.Nov 25 2019, 11:32 PM

• nray updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 26 2019, 12:00 AM